Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 44e1cf9b200cc3c09bddf918a134b68ba8961cf7..1141cac426fd1c4eb3db7043ac65de333bba7f39 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -294,6 +294,9 @@ Textfield::Textfield()
set_drag_controller(this);
GetRenderText()->SetFontList(GetDefaultFontList());
SetBorder(std::unique_ptr<Border>(new FocusableBorder()));
+
+ // On Mac, only textfields and list controls are focusable by default. Hence
tapted 2016/04/20 06:05:58 Same here. E.g. saying "only <foo>" suggests we're
karandeepb 2016/05/03 02:54:13 Done.
+ // use ALWAYS focus behavior.
SetFocusBehavior(FocusBehavior::ALWAYS);
if (ViewsDelegate::GetInstance()) {

Powered by Google App Engine
This is Rietveld 408576698