ui/views/controls/table/table_view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/table/table_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Rebased. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/controls/label.cc ('K') | « ui/views/controls/tabbed_pane/tabbed_pane.cc ('k') | ui/views/controls/textfield/textfield.cc » ('j') | ui/views/controls/textfield/textfield.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/table/table_view.cc

diff --git a/ui/views/controls/table/table_view.cc b/ui/views/controls/table/table_view.cc

index 04b94f57ff3ee10c3f96b8ffc2369365065095ed..b5b6b196b7a9dc92e70de5818cc59fa3c5185145 100644

--- a/ui/views/controls/table/table_view.cc

+++ b/ui/views/controls/table/table_view.cc

@@ -145,6 +145,9 @@ TableView::TableView(ui::TableModel* model,

visible_column.column = columns[i];

visible_columns_.push_back(visible_column);

}

+ // On Mac, except textfields and lists, no control should be focusable by

+ // default. In Cocoa, lists are generally represented using NSTableView. Hence

+ // use ALWAYS focus behavior for TableView.

tapted 2016/04/20 06:05:58 This comment feels out of place. I think it's enou

karandeepb 2016/05/03 02:54:12 Done.

SetFocusBehavior(FocusBehavior::ALWAYS);

SetModel(model);

}

« ui/views/controls/label.cc ('K') | « ui/views/controls/tabbed_pane/tabbed_pane.cc ('k') | ui/views/controls/textfield/textfield.cc » ('j') | ui/views/controls/textfield/textfield.cc » ('J')