ui/views/controls/tree/tree_view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/tree/tree_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Rebased. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/controls/textfield/textfield.cc ('K') | « ui/views/controls/textfield/textfield.cc ('k') | ui/views/examples/button_example.cc » ('j') | ui/views/focus/focus_traversal_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/tree/tree_view.cc

diff --git a/ui/views/controls/tree/tree_view.cc b/ui/views/controls/tree/tree_view.cc

index b9e76ed5c3c436a80a7cc7ce92976d594f6f9f51..482c4f89243fd03b7c44d7325c22b0fe277c0224 100644

--- a/ui/views/controls/tree/tree_view.cc

+++ b/ui/views/controls/tree/tree_view.cc

@@ -81,6 +81,8 @@ TreeView::TreeView()

controller_(NULL),

root_shown_(true),

row_height_(font_list_.GetHeight() + kTextVerticalPadding * 2) {

+ // On Mac, only textfields and lists are focusable by default. Since TreeView

+ // represents a list, use ALWAYS focus behavior.

tapted 2016/04/20 06:05:58 This could be // Always focusable, even on Mac (c

karandeepb 2016/05/03 02:54:13 Done.

SetFocusBehavior(FocusBehavior::ALWAYS);

closed_icon_ = *ui::ResourceBundle::GetSharedInstance().GetImageNamed(

(base::i18n::IsRTL() ? IDR_FOLDER_CLOSED_RTL