Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: ui/views/controls/label.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/label.cc
diff --git a/ui/views/controls/label.cc b/ui/views/controls/label.cc
index 8d46029a8041d452e6a702a0e891fe843c6b2aba..714aa891692ffe088f197318067db7daffcc4a0e 100644
--- a/ui/views/controls/label.cc
+++ b/ui/views/controls/label.cc
@@ -213,7 +213,7 @@ base::string16 Label::GetDisplayTextForTesting() {
gfx::Insets Label::GetInsets() const {
gfx::Insets insets = View::GetInsets();
- if (focusable()) {
+ if (focusable() || accessibility_focusable()) {
tapted 2016/04/20 06:05:58 oh butts - how many things call View::focusable()?
karandeepb 2016/05/03 02:54:12 Replaced this with focus_behavior() check. These a
insets += gfx::Insets(kFocusBorderPadding, kFocusBorderPadding,
kFocusBorderPadding, kFocusBorderPadding);
}
@@ -435,7 +435,7 @@ void Label::MaybeBuildRenderTextLines() {
return;
gfx::Rect rect = GetContentsBounds();
- if (focusable())
+ if (focusable() || accessibility_focusable())
rect.Inset(kFocusBorderPadding, kFocusBorderPadding);
if (rect.IsEmpty())
return;

Powered by Google App Engine
This is Rietveld 408576698