Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1893993002: Revert of Remove deprecated paths from image filter infrastructure. (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
Stephen White, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Remove deprecated paths from image filter infrastructure. (patchset #2 id:20001 of https://codereview.chromium.org/1888243003/ ) Reason for revert: Surprisingly (appallingly?), Chrome calls canFilterImageGPU Original issue's description: > Remove deprecated paths from image filter infrastructure. > > Now that there are no filterImageGPUDeprecated() implementations, > we can being to rip out the deprecated infrastructure. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1888243003 > > Committed: https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61 TBR=reed@google.com,senorblanco@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cb232e8b1b9f2d7831ad90815df5934ecafab1d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -28 lines) Patch
M include/core/SkDevice.h View 1 chunk +22 lines, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 5 chunks +51 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +27 lines, -23 lines 0 comments Download
M src/core/SkImageFilter.cpp View 4 chunks +87 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +107 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
robertphillips
Created Revert of Remove deprecated paths from image filter infrastructure.
4 years, 8 months ago (2016-04-17 21:31:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893993002/1
4 years, 8 months ago (2016-04-17 21:31:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cb232e8b1b9f2d7831ad90815df5934ecafab1d4
4 years, 8 months ago (2016-04-17 21:31:25 UTC) #4
Stephen White
4 years, 8 months ago (2016-04-18 16:53:39 UTC) #5
Message was sent while issue was closed.
D'oh. Chrome removal patch submitted here:
https://codereview.chromium.org/1900633002/

Powered by Google App Engine
This is Rietveld 408576698