Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1893743002: Renable warning suppression 4701 for GN (Windows). (Closed)

Created:
4 years, 8 months ago by Oliver Chang
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Oliver Chang
ptal. see https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/133385/steps/compile%20%28with%20patch%29/logs/stdio [3539/12599] CXX obj/third_party/pdfium/fxge/fx_agg_driver.obj FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" ...
4 years, 8 months ago (2016-04-15 21:44:01 UTC) #1
Oliver Chang
TBRing to unblock roll...
4 years, 8 months ago (2016-04-15 21:46:34 UTC) #3
Tom Sepez
RS LGTM
4 years, 8 months ago (2016-04-15 21:46:40 UTC) #4
Oliver Chang
4 years, 8 months ago (2016-04-15 21:47:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ba3dc72f73f8e6cdd0423d02a12528096c2d90a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698