Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: BUILD.gn

Issue 1893743002: Renable warning suppression 4701 for GN (Windows). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build_overrides/v8.gni") 5 import("//build_overrides/v8.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 import("pdfium.gni") 7 import("pdfium.gni")
8 8
9 config("pdfium_config") { 9 config("pdfium_config") {
10 cflags = [] 10 cflags = []
(...skipping 24 matching lines...) Expand all
35 if (is_linux) { 35 if (is_linux) {
36 if (current_cpu == "x64") { 36 if (current_cpu == "x64") {
37 defines += [ "_FX_CPU_=_FX_X64_" ] 37 defines += [ "_FX_CPU_=_FX_X64_" ]
38 cflags += [ "-fPIC" ] 38 cflags += [ "-fPIC" ]
39 } else if (current_cpu == "x86") { 39 } else if (current_cpu == "x86") {
40 defines += [ "_FX_CPU_=_FX_X86_" ] 40 defines += [ "_FX_CPU_=_FX_X86_" ]
41 } 41 }
42 } 42 }
43 43
44 if (is_win) { 44 if (is_win) {
45 cflags += [ "/wd4267" ] 45 cflags += [
46 "/wd4267",
47 "/wd4701",
48 ]
46 } 49 }
47 50
48 if (is_clang || is_posix) { 51 if (is_clang || is_posix) {
49 # TODO(thestig): Fix all instances, remove this, pdfium:29 52 # TODO(thestig): Fix all instances, remove this, pdfium:29
50 cflags += [ "-Wno-sign-compare" ] 53 cflags += [ "-Wno-sign-compare" ]
51 } 54 }
52 55
53 if (is_posix && !is_clang) { # When GCC. 56 if (is_posix && !is_clang) { # When GCC.
54 cflags += [ "-Wno-error=strict-overflow" ] 57 cflags += [ "-Wno-error=strict-overflow" ]
55 } 58 }
(...skipping 1660 matching lines...) Expand 10 before | Expand all | Expand 10 after
1716 "//v8:v8_libplatform", 1719 "//v8:v8_libplatform",
1717 ] 1720 ]
1718 include_dirs += [ 1721 include_dirs += [
1719 "//v8", 1722 "//v8",
1720 "//v8/include", 1723 "//v8/include",
1721 ] 1724 ]
1722 configs += [ "//v8:external_startup_data" ] 1725 configs += [ "//v8:external_startup_data" ]
1723 } 1726 }
1724 configs += [ ":pdfium_config" ] 1727 configs += [ ":pdfium_config" ]
1725 } 1728 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698