Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1885093002: Re-enable warning 4701 for GN build and some cleanup (Closed)

Created:
4 years, 8 months ago by Wei Li
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Re-enable warning 4701 for GN build and some cleanup Clean up three 4701 warnings (use potientially uninitialized variable) which are the only ones left; Re-enable warning 4701 for GN build; Remove an unused data structure; BUG=pdfium:29 Committed: https://pdfium.googlesource.com/pdfium/+/65ffa4a4ee599194118a0ddf3c26fc3674120b4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -35 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/localization/fgas_datetime.h View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Wei Li
PTAL, thanks
4 years, 8 months ago (2016-04-13 17:04:14 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-13 17:12:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885093002/1
4 years, 8 months ago (2016-04-13 17:12:11 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:26:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/65ffa4a4ee599194118a0ddf3c26fc367412...

Powered by Google App Engine
This is Rietveld 408576698