In SkDraw::drawRect, use SkPath for huge rects.

In SkDraw::drawRect, use SkPath for huge rects; fix the bugs in drawPath for huge rects.

The non-SkPath code doesn't correctly handle rects that out of range of SkIRect. It's simplest to just make the most general code path work rather than fix the bugs in all code paths.

Add bigrect gm. Previously committed as https://codereview.chromium.org/1758113005, but caused ASAN failures due to integer overflow and was reverted in https://codereview.chromium.org/1773593005. This CL adds increased coverage. The bigrect gm draws incorrectly in some cases due to skia:5199.

BUG=skia:5060
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893433002

[dogben, 2016-04-14 19:44:27]

Description was changed from

==========
In SkDraw::drawRect, use slow path for huge rects.

The code doesn't correctly handle rects that can't be converted to SkIRects, and
in particular SkScalarToFixed overflows in SkScan::HairRect.

Add bigrect gm, previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.

This CL transposes by 0.5 to ensure MSAA output is pixel-aligned.
==========

to

==========
In SkDraw::drawRect, use slow path for huge rects.

The code doesn't correctly handle rects that can't be converted to SkIRects, and
in particular SkScalarToFixed overflows in SkScan::HairRect.

Add bigrect gm, previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.

This CL transposes by 0.5 to ensure MSAA output is pixel-aligned.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-04-14 19:44:42]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 19:44:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/1

[commit-bot: I haz the power, 2016-04-14 19:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 19:58:56]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-04-14 20:45:17]

Description was changed from

==========
In SkDraw::drawRect, use slow path for huge rects.

The code doesn't correctly handle rects that can't be converted to SkIRects, and
in particular SkScalarToFixed overflows in SkScan::HairRect.

Add bigrect gm, previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.

This CL transposes by 0.5 to ensure MSAA output is pixel-aligned.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
In SkDraw::drawRect, use slow path for huge rects.

The code doesn't correctly handle rects that can't be converted to SkIRects, and
in particular SkScalarToFixed overflows in SkScan::HairRect.

Add bigrect gm, previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.

This CL transposes by 0.5 to ensure MSAA output is pixel-aligned.

BUG=skia:5060
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-04-15 13:27:52]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 13:28:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/20001

[commit-bot: I haz the power, 2016-04-15 13:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 13:30:31]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[dogben, 2016-04-15 13:45:49]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 13:45:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/40001

[dogben, 2016-04-15 13:47:35]

The CQ bit was unchecked by benjaminwagner@google.com

[dogben, 2016-04-15 14:08:13]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 14:08:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/60001

[commit-bot: I haz the power, 2016-04-15 14:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 14:12:10]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[dogben, 2016-04-19 02:12:59]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 02:13:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/80001

[commit-bot: I haz the power, 2016-04-19 02:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 02:22:55]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-04-19 20:01:29]

Patchset #5 (id:80001) has been deleted

[dogben, 2016-04-19 20:01:33]

Patchset #4 (id:60001) has been deleted

[dogben, 2016-04-19 20:01:38]

Patchset #3 (id:40001) has been deleted

[dogben, 2016-04-19 20:01:44]

Patchset #2 (id:20001) has been deleted

[dogben, 2016-04-19 20:01:48]

Patchset #1 (id:1) has been deleted

[dogben, 2016-04-19 20:06:22]

Description was changed from

==========
In SkDraw::drawRect, use slow path for huge rects.

The code doesn't correctly handle rects that can't be converted to SkIRects, and
in particular SkScalarToFixed overflows in SkScan::HairRect.

Add bigrect gm, previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.

This CL transposes by 0.5 to ensure MSAA output is pixel-aligned.

BUG=skia:5060
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
In SkDraw::drawRect, use SkPath for huge rects; fix the bugs in drawPath for
huge rects.

The non-SkPath code doesn't correctly handle rects that out of range of SkIRect.
It's simplest to just make the most general code path work rather than fix the
bugs in all code paths.

Add bigrect gm. Previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.
This CL adds increased coverage.

BUG=skia:5060
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-04-19 20:06:33]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 20:06:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/100001

[dogben, 2016-04-19 20:06:53]

The CQ bit was unchecked by benjaminwagner@google.com

[dogben, 2016-04-19 20:07:12]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 20:07:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433002/100001

[commit-bot: I haz the power, 2016-04-19 20:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 20:20:13]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-04-20 18:51:05]

benjaminwagner@google.com changed reviewers:
+ reed@google.com

[dogben, 2016-04-20 18:51:06]

reed: Sending to you for review because this CL adds new APIs:
  - SkRect::MakeLargestS32
  - SkRect::canRound
  - SkRegion::quickContains(SkRect) (existing version works on SkIRect)
  - SK_MaxS32Scalar

ccing mtklein because he reviewed the previous incarnation of gm/bigrect.cpp.

There are Gold diffs for tiles_rt-8888, but mtklein seems to think these are ok.
The diffs occur where there is a vertical hairline stroke at a tile boundary.

[dogben, 2016-04-20 18:53:50]

Description was changed from

==========
In SkDraw::drawRect, use SkPath for huge rects; fix the bugs in drawPath for
huge rects.

The non-SkPath code doesn't correctly handle rects that out of range of SkIRect.
It's simplest to just make the most general code path work rather than fix the
bugs in all code paths.

Add bigrect gm. Previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.
This CL adds increased coverage.

BUG=skia:5060
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
In SkDraw::drawRect, use SkPath for huge rects; fix the bugs in drawPath for
huge rects.

The non-SkPath code doesn't correctly handle rects that out of range of SkIRect.
It's simplest to just make the most general code path work rather than fix the
bugs in all code paths.

Add bigrect gm. Previously committed as
https://codereview.chromium.org/1758113005, but caused ASAN failures due to
integer overflow and was reverted in https://codereview.chromium.org/1773593005.
This CL adds increased coverage. The bigrect gm draws incorrectly in some cases
due to skia:5199.

BUG=skia:5060
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========