Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1773593005: Revert of Add BigRectGM. (Closed)

Created:
4 years, 9 months ago by dogben
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add BigRectGM. (patchset #2 id:20001 of https://codereview.chromium.org/1758113005/ ) Reason for revert: Causing ASAN failures. (I had expected float-cast ASAN failures, which are disabled right now, but we're also seeing integer overflows.) Original issue's description: > Add BigRectGM. > > BUG=skia:5060 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758113005 > > Committed: https://skia.googlesource.com/skia/+/a9101eef5ffc5f329a5edc75fd67441d868b0e9b TBR=mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5060 Committed: https://skia.googlesource.com/skia/+/54887a6a2e12b0f2c93e039b00678732b6518826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -85 lines) Patch
D gm/bigrect.cpp View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dogben
Created Revert of Add BigRectGM.
4 years, 9 months ago (2016-03-07 17:09:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773593005/1
4 years, 9 months ago (2016-03-07 17:09:13 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 17:09:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/54887a6a2e12b0f2c93e039b00678732b6518826

Powered by Google App Engine
This is Rietveld 408576698