Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1758113005:
Add BigRectGM. (Closed)
DescriptionAdd BigRectGM.
BUG=skia:5060
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758113005
Committed: https://skia.googlesource.com/skia/+/a9101eef5ffc5f329a5edc75fd67441d868b0e9b
Patch Set 1 #
Total comments: 6
Patch Set 2 : Use DEF_SIMPLE_GM. #Messages
Total messages: 19 (8 generated)
Description was changed from ========== Add BigRectGM. BUG=skia:5060 ========== to ========== Add BigRectGM. BUG=skia:5060 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758113005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
benjaminwagner@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp File gm/bigrect.cpp (right): https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp#newcode10 gm/bigrect.cpp:10: namespace skiagm { Generally no need for this. I guess it's fine if you like it. https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp#newcode13 gm/bigrect.cpp:13: class BigRectGM : public GM { I think this can use DEF_SIMPLE_GM or DEF_SIMPLE_GM_BG? https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp#newcode113 gm/bigrect.cpp:113: // DEF_GM(return new BigRectGM;) Let's land it on?
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758113005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758113005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp File gm/bigrect.cpp (right): https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp#newcode10 gm/bigrect.cpp:10: namespace skiagm { On 2016/03/07 at 14:32:12, mtklein wrote: > Generally no need for this. I guess it's fine if you like it. Removed. https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp#newcode13 gm/bigrect.cpp:13: class BigRectGM : public GM { On 2016/03/07 at 14:32:12, mtklein wrote: > I think this can use DEF_SIMPLE_GM or DEF_SIMPLE_GM_BG? Done. https://codereview.chromium.org/1758113005/diff/1/gm/bigrect.cpp#newcode113 gm/bigrect.cpp:113: // DEF_GM(return new BigRectGM;) On 2016/03/07 at 14:32:12, mtklein wrote: > Let's land it on? Sure, I'll add an ignore rule to gold instead.
lgtm
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758113005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758113005/20001
Message was sent while issue was closed.
Description was changed from ========== Add BigRectGM. BUG=skia:5060 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add BigRectGM. BUG=skia:5060 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/a9101eef5ffc5f329a5edc75fd67441d868b0e9b ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/a9101eef5ffc5f329a5edc75fd67441d868b0e9b
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1773593005/ by benjaminwagner@google.com. The reason for reverting is: Causing ASAN failures. (I had expected float-cast ASAN failures, which are disabled right now, but we're also seeing integer overflows.). |
