Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1893353002: Revert of [clang] Enable compilation of compiler runtime for iOS simulator. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, dmikurube+clang_chromium.org, eugenis+clang_chromium.org, glider+clang_chromium.org, hans, stkhapugin, ukai+watch_chromium.org, yunlian
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [clang] Enable compilation of compiler runtime for iOS simulator. (patchset #2 id:20001 of https://codereview.chromium.org/1883723003/ ) Reason for revert: Breaks clang tot bots: https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/8735 [3388/3417] Building CXX object lib/tsan/CMakeFiles/clang_rt.tsan_osx_dynamic.dir/rtl/tsan_interface_ann.cc.o FAILED: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -Dclang_rt_tsan_iossim_dynamic_EXPORTS -DLLVM_FORCE_HEAD_REVISION -Wall -std=c++11 -O3 -DNDEBUG -arch x86_64 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -fPIC -I/b/build/slave/ClangToTMac/build/src/third_party/llvm/compiler-rt/lib/tsan/.. -stdlib=libc++ -miphoneos-version-min=7.0 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.0.sdk -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fvisibility=hidden -fvisibility-inlines-hidden -fno-function-sections -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -fPIE -fno-rtti -msse3 -Wframe-larger-than=512 -Wglobal-constructors -MMD -MT lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_mac.cc.o -MF lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_mac.cc.o.d -o lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_mac.cc.o -c /b/build/slave/ClangToTMac/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cc /b/build/slave/ClangToTMac/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cc:24:10: fatal error: 'xpc/xpc.h' file not found #include <xpc/xpc.h> ^ Maybe that file shouldn't be built in iOS builds? Looks like some upstream build config problem; for now revert to get our bots back green. Original issue's description: > [clang] Enable compilation of compiler runtime for iOS simulator. > > This is required to enable ASan and coverage on simulators (and > other tools like UBSan, TSan, ...). > > BUG=450379, 602649 > > Committed: https://crrev.com/d957e66e8df2c23d18b9ef64a06088c1b6578fc3 > Cr-Commit-Position: refs/heads/master@{#387832} TBR=sdefresne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=450379, 602649 Committed: https://crrev.com/3194921862487f646d137dcc90e185b27c2e5cb7 Cr-Commit-Position: refs/heads/master@{#387914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M tools/clang/scripts/package.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Nico
Created Revert of [clang] Enable compilation of compiler runtime for iOS simulator.
4 years, 8 months ago (2016-04-18 14:13:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893353002/1
4 years, 8 months ago (2016-04-18 14:14:01 UTC) #2
sdefresne
lgtm ;-(
4 years, 8 months ago (2016-04-18 14:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893353002/1
4 years, 8 months ago (2016-04-18 14:18:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893353002/1
4 years, 8 months ago (2016-04-18 14:31:38 UTC) #5
Nico
filed https://llvm.org/bugs/show_bug.cgi?id=27403
4 years, 8 months ago (2016-04-18 14:32:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893353002/1
4 years, 8 months ago (2016-04-18 15:01:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893353002/1
4 years, 8 months ago (2016-04-18 15:31:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 15:37:12 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 15:39:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3194921862487f646d137dcc90e185b27c2e5cb7
Cr-Commit-Position: refs/heads/master@{#387914}

Powered by Google App Engine
This is Rietveld 408576698