[clang] Enable compilation of compiler runtime for iOS simulator.

[clang] Enable compilation of compiler runtime for iOS simulator.

This is required to enable ASan and coverage on simulators (and
other tools like UBSan, TSan, ...).

BUG=450379, 602649
Committed: https://crrev.com/d957e66e8df2c23d18b9ef64a06088c1b6578fc3
Cr-Commit-Position: refs/heads/master@{#387832}

[sdefresne, 2016-04-13 13:59:47]

Description was changed from

==========
[clang] Enable compilation of compiler runtime for ios simulator.

This is required to enable ASan and coverage on simulators (and
other tools like UBSan, TSan, ...).

BUG=450379,602649
==========

to

==========
[clang] Enable compilation of compiler runtime for iOS simulator.

This is required to enable ASan and coverage on simulators (and
other tools like UBSan, TSan, ...).

BUG=450379,602649
==========

[sdefresne, 2016-04-13 14:00:31]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2016-04-13 14:00:32]

Please take a look.

This build the required runtime support for simulator:
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.10.4.a
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.asan_iossim_dynamic.dylib
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.asan_osx_dynamic.dylib
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.cc_kext.a
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.eprintf.a
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.osx.a
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.profile_iossim.a
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.profile_osx.a
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.tsan_iossim_dynamic.dylib
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.tsan_osx_dynamic.dylib
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.ubsan_iossim_dynamic.dylib
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.ubsan_osx_dynamic.dylib

[sdefresne, 2016-04-13 14:01:22]

On 2016/04/13 at 14:00:32, sdefresne wrote:
> Please take a look.
> 
> This build the required runtime support for simulator:
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.10.4.a
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.asan_iossim_dynamic.dylib
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.asan_osx_dynamic.dylib
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.cc_kext.a
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.eprintf.a
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.osx.a
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.profile_iossim.a
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.profile_osx.a
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.tsan_iossim_dynamic.dylib
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.tsan_osx_dynamic.dylib
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.ubsan_iossim_dynamic.dylib
>
third_party/llvm-build/Release+Asserts/lib/clang/3.9.0/lib/darwin/libclang_rt.ubsan_osx_dynamic.dylib

BTW, I don't know if there is anything else besides changing this script to
deploy the runtime, so can you tell me if I need to do anything more.

[sdefresne, 2016-04-13 14:12:08]

+stkhapugin: FYI

Note that we only need runtime for iOS simulator for ASan since we only plan to
run it on simulator.

[Nico, 2016-04-13 18:27:42]

Hey cool, thanks! I think you also need to edit tools/clang/scripts/package.py
around line 217 to package profile_iossim. Other than that, looks great.

[Nico, 2016-04-13 18:27:55]

(+hans fyi)

[sdefresne, 2016-04-14 12:37:27]

Please take a look.

[Nico, 2016-04-15 20:05:25]

lgtm, thanks!

[sdefresne, 2016-04-17 10:39:51]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-04-17 10:39:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883723003/20001

[commit-bot: I haz the power, 2016-04-17 12:03:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-17 12:04:10]

Description was changed from

==========
[clang] Enable compilation of compiler runtime for iOS simulator.

This is required to enable ASan and coverage on simulators (and
other tools like UBSan, TSan, ...).

BUG=450379,602649
==========

to

==========
[clang] Enable compilation of compiler runtime for iOS simulator.

This is required to enable ASan and coverage on simulators (and
other tools like UBSan, TSan, ...).

BUG=450379,602649

Committed: https://crrev.com/d957e66e8df2c23d18b9ef64a06088c1b6578fc3
Cr-Commit-Position: refs/heads/master@{#387832}
==========

[commit-bot: I haz the power, 2016-04-17 12:04:12]

Patchset 2 (id:??) landed as
https://crrev.com/d957e66e8df2c23d18b9ef64a06088c1b6578fc3
Cr-Commit-Position: refs/heads/master@{#387832}

[Nico, 2016-04-18 14:13:51]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1893353002/ by thakis@chromium.org.

The reason for reverting is: Breaks clang tot bots:

https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/8735

[3388/3417] Building CXX object
lib/tsan/CMakeFiles/clang_rt.tsan_osx_dynamic.dir/rtl/tsan_interface_ann.cc.o
FAILED:
/Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
  -Dclang_rt_tsan_iossim_dynamic_EXPORTS -DLLVM_FORCE_HEAD_REVISION -Wall
-std=c++11 -O3 -DNDEBUG -arch x86_64 -isysroot
/Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk
-fPIC
-I/b/build/slave/ClangToTMac/build/src/third_party/llvm/compiler-rt/lib/tsan/.. 
   -stdlib=libc++ -miphoneos-version-min=7.0 -isysroot
/Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.0.sdk
-fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables
-fno-stack-protector -fvisibility=hidden -fvisibility-inlines-hidden
-fno-function-sections -fno-lto -O3 -gline-tables-only -Wno-gnu
-Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -fPIE -fno-rtti
-msse3 -Wframe-larger-than=512 -Wglobal-constructors -MMD -MT
lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_mac.cc.o
-MF
lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_mac.cc.o.d
-o
lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_mac.cc.o
-c
/b/build/slave/ClangToTMac/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cc
/b/build/slave/ClangToTMac/build/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cc:24:10:
fatal error: 'xpc/xpc.h' file not found
#include <xpc/xpc.h>
         ^

Maybe that file shouldn't be built in iOS builds? Looks like some upstream build
config problem; for now revert to get our bots back green..