Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1894023002: CC Animation: Make ElementAnimations a ref-counted object. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Make ElementAnimations a ref-counted object. It will be merged with ref-counted LayerAnimationController. In the future we may introduce blink::CompositorElementAnimations with m_elementAnimations wrapper which holds a ref-counted reference. A Drive-by: enhance the comment in ElementAnimations::OnAnimationWaitingForDeletion. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c Cr-Commit-Position: refs/heads/master@{#388067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -41 lines) Patch
M cc/animation/animation_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/animation/animation_host.cc View 6 chunks +12 lines, -15 lines 0 comments Download
M cc/animation/animation_player.h View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/animation/animation_player.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/animation/element_animations.h View 3 chunks +8 lines, -4 lines 0 comments Download
M cc/animation/element_animations.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-18 05:35:37 UTC) #4
ajuma
lgtm
4 years, 8 months ago (2016-04-18 13:20:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894023002/1
4 years, 8 months ago (2016-04-18 23:04:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:08:28 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:10:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c
Cr-Commit-Position: refs/heads/master@{#388067}

Powered by Google App Engine
This is Rietveld 408576698