Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892813004: Avoid narrowing of strings in FWL SetEditText methods. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid narrowing of strings in FWL SetEditText methods. Committed: https://pdfium.googlesource.com/pdfium/+/31e446374a7cf3f3353e42a03b6d5297e5cd60ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M xfa/fwl/lightwidget/cfwl_combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_combobox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, more of the same.
4 years, 8 months ago (2016-04-15 22:36:54 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-15 22:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892813004/1
4 years, 8 months ago (2016-04-15 23:04:05 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:04:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/31e446374a7cf3f3353e42a03b6d5297e5cd...

Powered by Google App Engine
This is Rietveld 408576698