xfa/fwl/lightwidget/cfwl_combobox.cpp - Issue 1892813004: Avoid narrowing of strings in FWL SetEditText methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/lightwidget/cfwl_combobox.cpp

Issue 1892813004: Avoid narrowing of strings in FWL SetEditText methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/lightwidget/cfwl_combobox.cpp

diff --git a/xfa/fwl/lightwidget/cfwl_combobox.cpp b/xfa/fwl/lightwidget/cfwl_combobox.cpp

index bdcc36fa30324de6d985d782f4fdc146de4edc89..f2cd1f5d6b102b3716a848f537be3ddea2efd70f 100644

--- a/xfa/fwl/lightwidget/cfwl_combobox.cpp

+++ b/xfa/fwl/lightwidget/cfwl_combobox.cpp

@@ -88,7 +88,7 @@ FWL_ERR CFWL_ComboBox::SetCurSel(int32_t iSel) {

return static_cast<IFWL_ComboBox*>(m_pIface)->SetCurSel(iSel);

}

-FWL_ERR CFWL_ComboBox::SetEditText(const CFX_WideStringC& wsText) {

+FWL_ERR CFWL_ComboBox::SetEditText(const CFX_WideString& wsText) {

if (!m_pIface)

return FWL_ERR_Indefinite;

return static_cast<IFWL_ComboBox*>(m_pIface)->SetEditText(wsText);

« no previous file with comments | « xfa/fwl/lightwidget/cfwl_combobox.h ('k') | xfa/fwl/lightwidget/cfwl_datetimepicker.h » ('j') | no next file with comments »