xfa/fwl/lightwidget/cfwl_combobox.h - Issue 1892813004: Avoid narrowing of strings in FWL SetEditText methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/lightwidget/cfwl_combobox.h

Issue 1892813004: Avoid narrowing of strings in FWL SetEditText methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/lightwidget/cfwl_combobox.h

diff --git a/xfa/fwl/lightwidget/cfwl_combobox.h b/xfa/fwl/lightwidget/cfwl_combobox.h

index 59b542c453dfede816c00827244af7451f5cc53c..c92a063cdff85512532c7de8b965e57294eefcbb 100644

--- a/xfa/fwl/lightwidget/cfwl_combobox.h

+++ b/xfa/fwl/lightwidget/cfwl_combobox.h

@@ -30,7 +30,7 @@ class CFWL_ComboBox : public CFWL_Widget {

FWL_ERR GetTextByIndex(int32_t iIndex, CFX_WideString& wsText);

int32_t GetCurSel();

FWL_ERR SetCurSel(int32_t iSel);

- FWL_ERR SetEditText(const CFX_WideStringC& wsText);

+ FWL_ERR SetEditText(const CFX_WideString& wsText);

int32_t GetEditTextLength() const;

FWL_ERR GetEditText(CFX_WideString& wsText,

int32_t nStart = 0,

« no previous file with comments | « no previous file | xfa/fwl/lightwidget/cfwl_combobox.cpp » ('j') | no next file with comments »