Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1892703002: Moves WmEvent to ash/wm/common (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves WmEvent to ash/wm/common TBR as trivial move. BUG=603369 TEST=covered by tests R=oshima@chromium.org TBR=oshima@chromium.org Committed: https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e Cr-Commit-Position: refs/heads/master@{#387489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -195 lines) Patch
M ash/accelerators/accelerator_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/wm/common/wm_event.h View 3 chunks +4 lines, -5 lines 0 comments Download
A + ash/wm/common/wm_event.cc View 1 chunk +5 lines, -11 lines 0 comments Download
M ash/wm/default_state.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/wm_event.h View 1 chunk +0 lines, -123 lines 0 comments Download
D ash/wm/wm_event.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sky
4 years, 8 months ago (2016-04-14 23:48:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892703002/1
4 years, 8 months ago (2016-04-14 23:49:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 00:23:10 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 00:24:58 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e
Cr-Commit-Position: refs/heads/master@{#387489}

Powered by Google App Engine
This is Rietveld 408576698