Moving device description utils from AudioManager[Base] into AudioDeviceDescription; to be shared b…

Moving device description utils from AudioManager[Base] into AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581
Committed: https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77
Cr-Commit-Position: refs/heads/master@{#390086}

[o1ka, 2016-04-15 15:09:40]

olka@chromium.org changed reviewers:
+ ben@chromium.org

[o1ka, 2016-04-15 15:09:42]

Could you PTAL?
(dalecurtis@ would be the main reviewer, but he is OOO)
Thanks!
Olga

[DaleCurtis, 2016-04-20 19:29:34]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-04-20 19:29:34]

media/ lgtm

[o1ka, 2016-04-21 10:52:17]

Description was changed from

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581
==========

to

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581
==========

[o1ka, 2016-04-21 10:52:17]

olka@chromium.org changed reviewers:
- ben@chromium.org

[o1ka, 2016-04-21 10:55:42]

olka@chromium.org changed reviewers:
+ jochen@chromium.org

[o1ka, 2016-04-21 10:55:42]

(changing non-media reviewer)
jochen@chromium.org: Please review non-media changes.
DaleCurtis@ - thanks for the review!

[jochen (gone - plz use gerrit), 2016-04-21 14:42:17]

lgtm

[o1ka, 2016-04-22 07:40:32]

The CQ bit was checked by olka@chromium.org

[commit-bot: I haz the power, 2016-04-22 07:40:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892433002/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892433002/10001

[commit-bot: I haz the power, 2016-04-22 07:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 07:43:14]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[o1ka, 2016-04-25 08:35:21]

The CQ bit was checked by olka@chromium.org

[o1ka, 2016-04-25 08:35:22]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1892433002/#ps30001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-25 08:35:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892433002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892433002/30001

[commit-bot: I haz the power, 2016-04-25 08:37:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 08:37:50]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[o1ka, 2016-04-27 13:55:49]

Patchset #4 (id:50001) has been deleted

[o1ka, 2016-04-27 15:44:15]

The CQ bit was checked by olka@chromium.org

[o1ka, 2016-04-27 15:44:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1892433002/#ps70001
(title: "another rebase")

[commit-bot: I haz the power, 2016-04-27 15:44:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892433002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892433002/70001

[commit-bot: I haz the power, 2016-04-27 15:50:27]

Description was changed from

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581
==========

to

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581
==========

[commit-bot: I haz the power, 2016-04-27 15:50:29]

Committed patchset #4 (id:70001)

[commit-bot: I haz the power, 2016-04-30 17:10:11]

Patchset 4 (id:??) landed as
https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77
Cr-Commit-Position: refs/heads/master@{#390086}

[commit-bot: I haz the power, 2016-04-30 17:50:10]

Description was changed from

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581
==========

to

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581

Committed: https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77
Cr-Commit-Position: refs/heads/master@{#390086}
==========

[o1ka, 2016-05-12 13:42:15]

Description was changed from

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581

Committed: https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77
Cr-Commit-Position: refs/heads/master@{#390086}
==========

to

==========
Moving device description utils from AudioManager[Base] into
AudioDeviceDescription; to be shared by browser/renderer

Moved from AudioManagerBase:
* device id constants,
* IsDefaultDeviceId() (renamed to IsDefaultDevice)
* UseSessionIdToSelectDevice()

Moved from AudioManager:
* GetDefaultDeviceName()
* GetCommuncationDeviceName()

AudioDeviceName:
introduced two static helpers: CreateDefault and CreateCommunications

The rest is renaming and header include fixes.

BUG=602581

Committed: https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77
Cr-Commit-Position: refs/heads/master@{#390086}
==========