Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4045)

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Issue 1892433002: Moving device description utils from AudioManager[Base] into AudioDeviceDescription; to be shared b… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
index dfc6882cd38e8a88451c8699aafa174d8c262ae7..ff15998590e55b69746097cd67645d4321cc4d6b 100644
--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
@@ -19,7 +19,7 @@
#include "extensions/browser/extension_registry.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/permissions/permissions_data.h"
-#include "media/audio/audio_manager_base.h"
+#include "media/audio/audio_device_description.h"
#include "media/audio/audio_output_controller.h"
namespace extensions {
@@ -195,8 +195,8 @@ std::string WebrtcAudioPrivateFunction::CalculateHMACImpl(
// that transforms "default" to the empty string, and code in
// GetActiveSink that ensures we return "default" if we get the
// empty string as the current device ID.
- if (raw_id.empty() || raw_id == media::AudioManagerBase::kDefaultDeviceId)
- return media::AudioManagerBase::kDefaultDeviceId;
+ if (media::AudioDeviceDescription::IsDefaultDevice(raw_id))
+ return media::AudioDeviceDescription::kDefaultDeviceId;
GURL security_origin(source_url().GetOrigin());
return content::GetHMACForMediaDeviceID(device_id_salt(), security_origin,
@@ -297,7 +297,7 @@ void WebrtcAudioPrivateGetActiveSinkFunction::OnHMACCalculated(
std::string result = hmac_id;
if (result.empty()) {
DVLOG(2) << "Received empty ID, replacing with default ID.";
- result = media::AudioManagerBase::kDefaultDeviceId;
+ result = media::AudioDeviceDescription::kDefaultDeviceId;
}
results_.reset(wap::GetActiveSink::Results::Create(result).release());
SendResponse(true);
@@ -368,7 +368,7 @@ void WebrtcAudioPrivateSetActiveSinkFunction::OnOutputDeviceNames(
DCHECK_CURRENTLY_ON(BrowserThread::IO);
std::string raw_sink_id;
- if (sink_id_ == media::AudioManagerBase::kDefaultDeviceId) {
+ if (sink_id_ == media::AudioDeviceDescription::kDefaultDeviceId) {
DVLOG(2) << "Received default ID, replacing with empty ID.";
raw_sink_id = "";
} else {
@@ -491,7 +491,7 @@ void WebrtcAudioPrivateGetAssociatedSinkFunction::OnHMACCalculated(
const std::string& associated_sink_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (associated_sink_id == media::AudioManagerBase::kDefaultDeviceId) {
+ if (associated_sink_id == media::AudioDeviceDescription::kDefaultDeviceId) {
DVLOG(2) << "Got default ID, replacing with empty ID.";
results_.reset(wap::GetAssociatedSink::Results::Create("").release());
} else {

Powered by Google App Engine
This is Rietveld 408576698