Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

Issue 1892433002: Moving device description utils from AudioManager[Base] into AudioDeviceDescription; to be shared b… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/json/json_writer.h" 7 #include "base/json/json_writer.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 12 matching lines...) Expand all
23 #include "chrome/browser/ui/browser.h" 23 #include "chrome/browser/ui/browser.h"
24 #include "chrome/browser/ui/tabs/tab_strip_model.h" 24 #include "chrome/browser/ui/tabs/tab_strip_model.h"
25 #include "chrome/test/base/in_process_browser_test.h" 25 #include "chrome/test/base/in_process_browser_test.h"
26 #include "chrome/test/base/ui_test_utils.h" 26 #include "chrome/test/base/ui_test_utils.h"
27 #include "content/public/browser/browser_thread.h" 27 #include "content/public/browser/browser_thread.h"
28 #include "content/public/browser/media_device_id.h" 28 #include "content/public/browser/media_device_id.h"
29 #include "content/public/browser/web_contents.h" 29 #include "content/public/browser/web_contents.h"
30 #include "content/public/test/browser_test_utils.h" 30 #include "content/public/test/browser_test_utils.h"
31 #include "extensions/common/permissions/permission_set.h" 31 #include "extensions/common/permissions/permission_set.h"
32 #include "extensions/common/permissions/permissions_data.h" 32 #include "extensions/common/permissions/permissions_data.h"
33 #include "media/audio/audio_device_description.h"
33 #include "media/audio/audio_manager.h" 34 #include "media/audio/audio_manager.h"
34 #include "media/audio/audio_manager_base.h"
35 #include "net/test/embedded_test_server/embedded_test_server.h" 35 #include "net/test/embedded_test_server/embedded_test_server.h"
36 #include "testing/gtest/include/gtest/gtest.h" 36 #include "testing/gtest/include/gtest/gtest.h"
37 37
38 using base::JSONWriter; 38 using base::JSONWriter;
39 using content::RenderProcessHost; 39 using content::RenderProcessHost;
40 using content::WebContents; 40 using content::WebContents;
41 using media::AudioDeviceNames; 41 using media::AudioDeviceNames;
42 using media::AudioManager; 42 using media::AudioManager;
43 43
44 namespace extensions { 44 namespace extensions {
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 size_t ix = 0; 192 size_t ix = 0;
193 AudioDeviceNames::const_iterator it = devices.begin(); 193 AudioDeviceNames::const_iterator it = devices.begin();
194 for (; ix < sink_list->GetSize() && it != devices.end(); 194 for (; ix < sink_list->GetSize() && it != devices.end();
195 ++ix, ++it) { 195 ++ix, ++it) {
196 base::DictionaryValue* dict = NULL; 196 base::DictionaryValue* dict = NULL;
197 sink_list->GetDictionary(ix, &dict); 197 sink_list->GetDictionary(ix, &dict);
198 std::string sink_id; 198 std::string sink_id;
199 dict->GetString("sinkId", &sink_id); 199 dict->GetString("sinkId", &sink_id);
200 200
201 std::string expected_id; 201 std::string expected_id;
202 if (it->unique_id.empty() || 202 if (media::AudioDeviceDescription::IsDefaultDevice(it->unique_id)) {
203 it->unique_id == media::AudioManagerBase::kDefaultDeviceId) { 203 expected_id = media::AudioDeviceDescription::kDefaultDeviceId;
204 expected_id = media::AudioManagerBase::kDefaultDeviceId;
205 } else { 204 } else {
206 GetIDInOrigin(profile()->GetResourceContext(), 205 GetIDInOrigin(profile()->GetResourceContext(),
207 source_url_.GetOrigin(), 206 source_url_.GetOrigin(),
208 it->unique_id, 207 it->unique_id,
209 &expected_id); 208 &expected_id);
210 } 209 }
211 210
212 EXPECT_EQ(expected_id, sink_id); 211 EXPECT_EQ(expected_id, sink_id);
213 std::string sink_label; 212 std::string sink_label;
214 dict->GetString("sinkLabel", &sink_label); 213 dict->GetString("sinkLabel", &sink_label);
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 title_watcher.AlsoWaitForTitle(base::ASCIIToUTF16("failure")); 427 title_watcher.AlsoWaitForTitle(base::ASCIIToUTF16("failure"));
429 base::string16 result = title_watcher.WaitAndGetTitle(); 428 base::string16 result = title_watcher.WaitAndGetTitle();
430 EXPECT_EQ(base::ASCIIToUTF16("success"), result); 429 EXPECT_EQ(base::ASCIIToUTF16("success"), result);
431 430
432 g_browser_process->webrtc_log_uploader()->OverrideUploadWithBufferForTesting( 431 g_browser_process->webrtc_log_uploader()->OverrideUploadWithBufferForTesting(
433 NULL); 432 NULL);
434 } 433 }
435 #endif // defined(GOOGLE_CHROME_BUILD) || defined(ENABLE_HANGOUT_SERVICES_EXTEN SION) 434 #endif // defined(GOOGLE_CHROME_BUILD) || defined(ENABLE_HANGOUT_SERVICES_EXTEN SION)
436 435
437 } // namespace extensions 436 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698