Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189233008: DevTools: remove the --remote-debugging-frontend flag. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
vsevik, jam, lushnikov, yurys
CC:
chromium-reviews, vsevik, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: remove the --remote-debugging-frontend flag. R=jam@chromium.org, lushnikov@chromium.org, vsevik@chromium.org TBR=jam (a simple flag removal) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256433

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comment addressed. #

Total comments: 3

Patch Set 3 : Removed overriden frontend notion from the backend entirely per lushnikov@'s offline suggestion. #

Patch Set 4 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -66 lines) Patch
M chrome/browser/browser_process.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/devtools/frontend/devtools_discovery_page.html View 1 2 3 4 chunks +43 lines, -30 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 2 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-08 14:33:54 UTC) #1
lushnikov
https://codereview.chromium.org/189233008/diff/1/content/browser/devtools/devtools_http_handler_impl.cc File content/browser/devtools/devtools_http_handler_impl.cc (left): https://codereview.chromium.org/189233008/diff/1/content/browser/devtools/devtools_http_handler_impl.cc#oldcode435 content/browser/devtools/devtools_http_handler_impl.cc:435: query = path.substr(query_pos + 1); what kind of query ...
6 years, 9 months ago (2014-03-08 15:15:17 UTC) #2
pfeldman
https://codereview.chromium.org/189233008/diff/1/content/browser/devtools/devtools_http_handler_impl.cc File content/browser/devtools/devtools_http_handler_impl.cc (left): https://codereview.chromium.org/189233008/diff/1/content/browser/devtools/devtools_http_handler_impl.cc#oldcode435 content/browser/devtools/devtools_http_handler_impl.cc:435: query = path.substr(query_pos + 1); On 2014/03/08 15:15:18, lushnikov ...
6 years, 9 months ago (2014-03-08 15:46:29 UTC) #3
lushnikov
lgtm
6 years, 9 months ago (2014-03-09 09:16:59 UTC) #4
vsevik
lgtm lgtm https://codereview.chromium.org/189233008/diff/20001/chrome/browser/devtools/remote_debugging_server.cc File chrome/browser/devtools/remote_debugging_server.cc (right): https://codereview.chromium.org/189233008/diff/20001/chrome/browser/devtools/remote_debugging_server.cc#newcode18 chrome/browser/devtools/remote_debugging_server.cc:18: "", Looks like this parameter is redundant ...
6 years, 9 months ago (2014-03-11 10:49:04 UTC) #5
vsevik
https://codereview.chromium.org/189233008/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc File content/browser/devtools/devtools_http_handler_impl.cc (right): https://codereview.chromium.org/189233008/diff/20001/content/browser/devtools/devtools_http_handler_impl.cc#newcode784 content/browser/devtools/devtools_http_handler_impl.cc:784: aux_url.is_valid() ? aux_url.spec() : frontend_url_; Is this is the ...
6 years, 9 months ago (2014-03-11 10:50:44 UTC) #6
yurys
I think we should start with updating our documentation and remove mentions of the flag ...
6 years, 9 months ago (2014-03-11 10:55:47 UTC) #7
pfeldman
https://codereview.chromium.org/189233008/diff/20001/chrome/browser/devtools/remote_debugging_server.cc File chrome/browser/devtools/remote_debugging_server.cc (right): https://codereview.chromium.org/189233008/diff/20001/chrome/browser/devtools/remote_debugging_server.cc#newcode18 chrome/browser/devtools/remote_debugging_server.cc:18: "", Android passes different value here.
6 years, 9 months ago (2014-03-11 11:16:06 UTC) #8
pfeldman
6 years, 9 months ago (2014-03-11 16:30:58 UTC) #9
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-11 16:31:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/189233008/40001
6 years, 9 months ago (2014-03-11 16:37:06 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 16:45:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-11 16:45:07 UTC) #13
lushnikov
On 2014/03/11 16:45:07, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-11 17:38:20 UTC) #14
jam
owners lgtm
6 years, 9 months ago (2014-03-11 23:23:08 UTC) #15
pfeldman
Committed patchset #4 manually as r256433 (presubmit successful).
6 years, 9 months ago (2014-03-12 05:06:55 UTC) #16
vivekg
The page at [1] still refers to this flag "remote-debugging-frontend". What is the alternative way ...
6 years, 8 months ago (2014-04-09 05:47:03 UTC) #17
pfeldman
6 years, 8 months ago (2014-04-09 09:13:26 UTC) #18
Message was sent while issue was closed. 
On 2014/04/09 05:47:03, vivekg_ wrote:
> The page at [1] still refers to this flag "remote-debugging-frontend". 
> 
> What is the alternative way of contributing to the frontend code since the
> removal of the above flag? 
> 
> [1] https://developers.google.com/chrome-developer-tools/docs/contributing

It is now http://localhost:9222#<front-end url>

Powered by Google App Engine
This is Rietveld 408576698