Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Side by Side Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 189233008: DevTools: remove the --remote-debugging-frontend flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comment addressed. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/remote_debugging_server.h" 5 #include "chrome/browser/devtools/remote_debugging_server.h"
6 6
7 #include "chrome/browser/devtools/browser_list_tabcontents_provider.h" 7 #include "chrome/browser/devtools/browser_list_tabcontents_provider.h"
8 #include "chrome/browser/ui/webui/devtools_ui.h" 8 #include "chrome/browser/ui/webui/devtools_ui.h"
9 #include "content/public/browser/devtools_http_handler.h" 9 #include "content/public/browser/devtools_http_handler.h"
10 #include "net/socket/tcp_listen_socket.h" 10 #include "net/socket/tcp_listen_socket.h"
11 11
12 RemoteDebuggingServer::RemoteDebuggingServer( 12 RemoteDebuggingServer::RemoteDebuggingServer(
13 chrome::HostDesktopType host_desktop_type, 13 chrome::HostDesktopType host_desktop_type,
14 const std::string& ip, 14 const std::string& ip,
15 int port, 15 int port) {
16 const std::string& frontend_url) {
17 devtools_http_handler_ = content::DevToolsHttpHandler::Start( 16 devtools_http_handler_ = content::DevToolsHttpHandler::Start(
18 new net::TCPListenSocketFactory(ip, port), 17 new net::TCPListenSocketFactory(ip, port),
19 frontend_url, 18 "",
vsevik 2014/03/11 10:49:05 Looks like this parameter is redundant now - we al
pfeldman 2014/03/11 11:16:06 Android passes different value here.
20 new BrowserListTabContentsProvider(host_desktop_type)); 19 new BrowserListTabContentsProvider(host_desktop_type));
21 } 20 }
22 21
23 RemoteDebuggingServer::~RemoteDebuggingServer() { 22 RemoteDebuggingServer::~RemoteDebuggingServer() {
24 devtools_http_handler_->Stop(); 23 devtools_http_handler_->Stop();
25 } 24 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698