chrome/browser/ui/website_settings/chooser_bubble_controller.h - Issue 1892293003: Display origin url on the chooser permission dialog title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/chooser_bubble_controller.h

Issue 1892293003: Display origin url on the chooser permission dialog title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc ('k') | chrome/browser/ui/website_settings/chooser_bubble_controller.cc » ('j') | chrome/browser/ui/website_settings/chooser_bubble_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/chooser_bubble_controller.h

diff --git a/chrome/browser/ui/website_settings/chooser_bubble_controller.h b/chrome/browser/ui/website_settings/chooser_bubble_controller.h

index 70f766053dcf6137992ee0d45ed680345c0b78ee..1308943c7c260dd9a064db1928a19f3f8895fd53 100644

--- a/chrome/browser/ui/website_settings/chooser_bubble_controller.h

+++ b/chrome/browser/ui/website_settings/chooser_bubble_controller.h

@@ -53,6 +53,9 @@ class ChooserBubbleController : public BubbleDelegate {

virtual ~Observer() {}

};

+ // Return the origin URL to be displayed on the bubble title.

+ GURL GetOriginUrl() const;

palmer 2016/04/18 18:28:10 I think it might make more conceptual sense to ret

juncai 2016/04/18 19:43:24 Done.

// Open help center URL.

void OpenHelpCenterUrl() const;