chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc - Issue 1892293003: Display origin url on the chooser permission dialog title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

Issue 1892293003: Display origin url on the chooser permission dialog title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/website_settings/chooser_bubble_controller.h » ('j') | chrome/browser/ui/website_settings/chooser_bubble_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

diff --git a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

index 1843c476ae0d3c94fc49f4ca372336b3f299b546..a8636f73cefbfb49a90f37c4e1905b1e82e784b8 100644

--- a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

+++ b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

@@ -24,6 +24,7 @@

#include "chrome/common/pref_names.h"

#include "chrome/grit/generated_resources.h"

#include "components/prefs/pref_service.h"

+#include "components/url_formatter/elide_url.h"

#include "ui/accessibility/ax_view_state.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"

@@ -189,7 +190,9 @@ bool ChooserBubbleUiViewDelegate::ShouldShowWindowTitle() const {

}

base::string16 ChooserBubbleUiViewDelegate::GetWindowTitle() const {

- return l10n_util::GetStringUTF16(IDS_CHOOSER_BUBBLE_PROMPT);

+ return l10n_util::GetStringFUTF16(

+ IDS_CHOOSER_BUBBLE_PROMPT,

+ url_formatter::FormatUrlForSecurityDisplay(controller_->GetOriginUrl()));

}

base::string16 ChooserBubbleUiViewDelegate::GetDialogButtonLabel(