Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/ui/website_settings/chooser_bubble_controller.h

Issue 1892293003: Display origin url on the chooser permission dialog title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_CONTROLLER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // Called when GetOption(index) is no longer present, and all later 46 // Called when GetOption(index) is no longer present, and all later
47 // options have been moved earlier by 1 slot. Calling GetOption(index) 47 // options have been moved earlier by 1 slot. Calling GetOption(index)
48 // from inside a call to OnOptionRemoved will NOT see the removed string 48 // from inside a call to OnOptionRemoved will NOT see the removed string
49 // since the options have already been updated. 49 // since the options have already been updated.
50 virtual void OnOptionRemoved(size_t index) = 0; 50 virtual void OnOptionRemoved(size_t index) = 0;
51 51
52 protected: 52 protected:
53 virtual ~Observer() {} 53 virtual ~Observer() {}
54 }; 54 };
55 55
56 // Return the origin URL to be displayed on the bubble title.
57 GURL GetOriginUrl() const;
palmer 2016/04/18 18:28:10 I think it might make more conceptual sense to ret
juncai 2016/04/18 19:43:24 Done.
58
56 // Open help center URL. 59 // Open help center URL.
57 void OpenHelpCenterUrl() const; 60 void OpenHelpCenterUrl() const;
58 61
59 // BubbleDelegate: 62 // BubbleDelegate:
60 std::string GetName() const override; 63 std::string GetName() const override;
61 std::unique_ptr<BubbleUi> BuildBubbleUi() override; 64 std::unique_ptr<BubbleUi> BuildBubbleUi() override;
62 const content::RenderFrameHost* OwningFrame() const override; 65 const content::RenderFrameHost* OwningFrame() const override;
63 66
64 // The number of options users can pick from. For example, it can be 67 // The number of options users can pick from. For example, it can be
65 // the number of USB/Bluetooth device names which are listed in the 68 // the number of USB/Bluetooth device names which are listed in the
(...skipping 24 matching lines...) Expand all
90 93
91 private: 94 private:
92 Browser* browser_; 95 Browser* browser_;
93 const content::RenderFrameHost* const owning_frame_; 96 const content::RenderFrameHost* const owning_frame_;
94 Observer* observer_ = nullptr; 97 Observer* observer_ = nullptr;
95 98
96 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleController); 99 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleController);
97 }; 100 };
98 101
99 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_CONTROLLER_H_ 102 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698