Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1892293003: Display origin url on the chooser permission dialog title (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
Reviewers:
palmer
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, Reilly Grant (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Display origin url on the chooser permission dialog title Instead of showing "This site wants to connect to:", the chooser permission dialog title needs to replace "This site" with the actual URL string of the site which requests the permission from the user. BUG=604031, 529950 Committed: https://crrev.com/2245f138687425230a9d8275b3e67dac11da4944 Cr-Commit-Position: refs/heads/master@{#388045}

Patch Set 1 : display origin url on the chooser permission dialog title #

Patch Set 2 : same as the previous one #

Patch Set 3 : updated comment #

Total comments: 8

Patch Set 4 : address palmer@'s comments #

Total comments: 2

Patch Set 5 : address palmer@'s comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/chooser_bubble_controller.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/chooser_bubble_controller.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
juncai
Please take a look.
4 years, 8 months ago (2016-04-15 22:11:14 UTC) #2
palmer
Thanks for doing this! Some UX and implementation thoughts. https://codereview.chromium.org/1892293003/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1892293003/diff/40001/chrome/app/generated_resources.grd#newcode14598 chrome/app/generated_resources.grd:14598: ...
4 years, 8 months ago (2016-04-18 18:28:10 UTC) #3
juncai
https://codereview.chromium.org/1892293003/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1892293003/diff/40001/chrome/app/generated_resources.grd#newcode14598 chrome/app/generated_resources.grd:14598: + <ph name="URL">$1<ex>https://www.google.com</ex></ph> wants to connect to: On 2016/04/18 ...
4 years, 8 months ago (2016-04-18 19:43:24 UTC) #4
palmer
LGTM % nit. https://codereview.chromium.org/1892293003/diff/60001/chrome/browser/ui/website_settings/chooser_bubble_controller.h File chrome/browser/ui/website_settings/chooser_bubble_controller.h (right): https://codereview.chromium.org/1892293003/diff/60001/chrome/browser/ui/website_settings/chooser_bubble_controller.h#newcode61 chrome/browser/ui/website_settings/chooser_bubble_controller.h:61: url::Origin GetOriginUrl() const; Nit: I'd probably ...
4 years, 8 months ago (2016-04-18 21:14:00 UTC) #5
juncai
https://codereview.chromium.org/1892293003/diff/60001/chrome/browser/ui/website_settings/chooser_bubble_controller.h File chrome/browser/ui/website_settings/chooser_bubble_controller.h (right): https://codereview.chromium.org/1892293003/diff/60001/chrome/browser/ui/website_settings/chooser_bubble_controller.h#newcode61 chrome/browser/ui/website_settings/chooser_bubble_controller.h:61: url::Origin GetOriginUrl() const; On 2016/04/18 21:13:59, palmer wrote: > ...
4 years, 8 months ago (2016-04-18 21:20:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892293003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892293003/80001
4 years, 8 months ago (2016-04-18 21:21:07 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-18 22:19:45 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:22:08 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2245f138687425230a9d8275b3e67dac11da4944
Cr-Commit-Position: refs/heads/master@{#388045}

Powered by Google App Engine
This is Rietveld 408576698