Display origin url on the chooser permission dialog title

chrome/browser/ui/website_settings/chooser_bubble_controller.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/chooser_bubble_controller.h"
 
 #include "chrome/browser/net/referrer.h"
 #include "chrome/browser/ui/browser_finder.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 
 ChooserBubbleController::ChooserBubbleController(
     content::RenderFrameHost* owner)
     : browser_(chrome::FindBrowserWithWebContents(
           content::WebContents::FromRenderFrameHost(owner))),
       owning_frame_(owner) {}
 
 ChooserBubbleController::~ChooserBubbleController() {}
 
+GURL ChooserBubbleController::GetOriginUrl() const {
+  return const_cast<content::RenderFrameHost*>(owning_frame_)

[palmer, 2016/04/18 18:28:10]

Is this const_cast necessary? If so, why? I think it's because
|GetLastCommittedURL| (and GetLastCommittedOrigin) are not declared const? I
wonder if that could be changed/refactored?

[juncai, 2016/04/18 19:43:24]

Yes, it is necessary because GetLastCommittedOrigin() is not declared const. And
I asked this question on the chromium dev forum, they pointed out the
documentation:
http://www.chromium.org/developers/content-module/content-api
"don't add the const identifier to interfaces. For interfaces implemented by the
embedder, we can't make assumptions about what the embedder needs to implement
it. For interfaces implemented by content, the implementation details doesn't
have to be exposed."

+      ->GetLastCommittedURL();

[palmer, 2016/04/18 18:28:10]

Try GetLastCommittedOrigin.

[juncai, 2016/04/18 19:43:24]

Done.

+}
+
 void ChooserBubbleController::OpenHelpCenterUrl() const {
   browser_->OpenURL(content::OpenURLParams(
       GetHelpCenterUrl(), content::Referrer(), NEW_FOREGROUND_TAB,
       ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false /* is_renderer_initiated */));
 }
 
 std::string ChooserBubbleController::GetName() const {
   return "ChooserBubble";
 }
 
 const content::RenderFrameHost* ChooserBubbleController::OwningFrame() const {
   return owning_frame_;
 }