|
|
Created:
7 years, 5 months ago by qsr Modified:
7 years, 5 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionRemove test checking for default touch icons.
Chrome will not handle default touch icons anymore as they are costly
in term of battery and request and most site do not have any. Sites that
want touch icons will need to have a <link> tag.
BUG=258963
R=mkosiba@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212033
Patch Set 1 #
Messages
Total messages: 20 (0 generated)
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Not lgtm This will break public API. We need to check impact before landing it. On Thursday, 11 July 2013, <commit-bot@chromium.org> wrote: > CQ is trying da patch. Follow status at > https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1 > > > https://chromiumcodereview.appspot.com/18903004/ >
For the record I unchecked the CQ bit following joth's NLGTM
On 2013/07/11 15:29:23, joth__google wrote: > Not lgtm > > This will break public API. We need to check impact before landing it. hmm.. I was under the impression that the classic WebView didn't download the touch icons by default. The WebViewTest#testGetFavicon test has a todo in it that seems to imply that the favicons are not downloaded by default. > > On Thursday, 11 July 2013, <mailto:commit-bot@chromium.org> wrote: > > CQ is trying da patch. Follow status at > > https://chromium-status.appspot.com/cq/qsr%40chromium.org/18903004/1 > > > > > > https://chromiumcodereview.appspot.com/18903004/ > >
joth -> You could switch to a LGTM now that the intent to unship has been LGTM'd?
lgtm For reference, the unship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FHQCKfxcZXU Thanks qsr!
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
Message was sent while issue was closed.
Change committed as 212033 |