Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 18903004: Remove test checking for default touch icons. (Closed)

Created:
7 years, 5 months ago by qsr
Modified:
7 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Remove test checking for default touch icons. Chrome will not handle default touch icons anymore as they are costly in term of battery and request and most site do not have any. Sites that want touch icons will need to have a <link> tag. BUG=258963 R=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
qsr
7 years, 5 months ago (2013-07-11 07:36:05 UTC) #1
mkosiba (inactive)
LGTM
7 years, 5 months ago (2013-07-11 12:20:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-11 12:21:36 UTC) #3
joth__google
Not lgtm This will break public API. We need to check impact before landing it. ...
7 years, 5 months ago (2013-07-11 15:29:23 UTC) #4
mkosiba (inactive)
For the record I unchecked the CQ bit following joth's NLGTM
7 years, 5 months ago (2013-07-11 15:33:01 UTC) #5
mkosiba (inactive)
On 2013/07/11 15:29:23, joth__google wrote: > Not lgtm > > This will break public API. ...
7 years, 5 months ago (2013-07-11 15:37:26 UTC) #6
qsr
joth -> You could switch to a LGTM now that the intent to unship has ...
7 years, 5 months ago (2013-07-15 08:01:05 UTC) #7
joth
lgtm For reference, the unship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FHQCKfxcZXU Thanks qsr!
7 years, 5 months ago (2013-07-15 16:58:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-16 08:04:36 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=59976
7 years, 5 months ago (2013-07-16 09:59:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-16 11:14:11 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=60079
7 years, 5 months ago (2013-07-16 12:44:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-16 13:07:45 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=135721
7 years, 5 months ago (2013-07-16 13:53:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-16 14:43:40 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=135774
7 years, 5 months ago (2013-07-16 15:29:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-16 17:18:26 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=135896
7 years, 5 months ago (2013-07-16 18:27:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18903004/1
7 years, 5 months ago (2013-07-17 07:51:12 UTC) #19
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 14:05:32 UTC) #20
Message was sent while issue was closed.
Change committed as 212033

Powered by Google App Engine
This is Rietveld 408576698