Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2497)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java

Issue 18903004: Remove test checking for default touch icons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java
index ae2c128ed411454bdcbcb7a32c1c0c07a13b4546..277d4ca09fd48c68d5058fcb347c05e9c9928b8a 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java
@@ -29,9 +29,6 @@ public class AwContentsClientFaviconTest extends AwTestBase {
"<link rel=\"icon\" href=\""+ FAVICON1_URL + "\" />",
"Body");
- private static final String TOUCHICON_URL = "apple-touch-icon.png";
- private static final String TOUCHICON_PRECOMPOSED_URL = "apple-touch-icon-precomposed.png";
-
private static final String TOUCHICON_REL_LINK = "touch.png";
private static final String TOUCHICON_REL_LINK_72 = "touch_72.png";
private static final String TOUCHICON_REL_URL = "/" + TOUCHICON_REL_LINK;
@@ -121,26 +118,6 @@ public class AwContentsClientFaviconTest extends AwTestBase {
}
@SmallTest
- public void testReceiveBasicTouchIconRoot() throws Throwable {
- init(new TestAwContentsClientTouchIcon());
- int callCount = mContentsClient.mFaviconHelper.getCallCount();
-
- // Use the favicon page url. Since this does not specify a link rel for touch icon,
- // we should get the default touch icon urls in the callback.
- final String pageUrl = mWebServer.setResponse(FAVICON1_PAGE_URL, FAVICON1_PAGE_HTML,
- CommonResources.getTextHtmlHeaders(true));
-
- loadUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(), pageUrl);
-
- mContentsClient.mFaviconHelper.waitForCallback(callCount, 2);
-
- HashMap<String, Boolean> touchIcons = mContentsClient.mFaviconHelper.mTouchIcons;
- assertEquals(2, touchIcons.size());
- assertFalse(touchIcons.get(mWebServer.getBaseUrl() + TOUCHICON_URL));
- assertTrue(touchIcons.get(mWebServer.getBaseUrl() + TOUCHICON_PRECOMPOSED_URL));
- }
-
- @SmallTest
public void testReceiveBasicTouchIconLinkRel() throws Throwable {
init(new TestAwContentsClientTouchIcon());
int callCount = mContentsClient.mFaviconHelper.getCallCount();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698