Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1890243002: Expand the Material Design hover as it fades out when a ripple is triggered. (Closed)

Created:
4 years, 8 months ago by bruthig
Modified:
4 years, 8 months ago
Reviewers:
varkha
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand the Material Design hover as it fades out when a ripple is triggered. BUG=582253 TEST=manual Committed: https://crrev.com/caf80a39907860be5a649a81e5418721faac2f98 Cr-Commit-Position: refs/heads/master@{#389377}

Patch Set 1 #

Patch Set 2 : Fixed ink_drop_hover_unittest.cc compile error. #

Total comments: 21

Patch Set 3 : Merge with master. #

Patch Set 4 : Optimized InkDropHover::AnimateFade() to not trigger a transformation animation if not required. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -35 lines) Patch
M ui/views/animation/ink_drop_animation_controller_impl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.cc View 7 chunks +11 lines, -7 lines 0 comments Download
M ui/views/animation/ink_drop_host_view.cc View 1 2 3 4 chunks +16 lines, -5 lines 0 comments Download
M ui/views/animation/ink_drop_hover.h View 1 2 3 4 chunks +25 lines, -4 lines 0 comments Download
M ui/views/animation/ink_drop_hover.cc View 1 2 3 4 chunks +37 lines, -16 lines 0 comments Download
M ui/views/animation/ink_drop_hover_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
bruthig
varkha@, can you PTAL?
4 years, 8 months ago (2016-04-15 19:36:19 UTC) #2
varkha
https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc File ui/views/animation/ink_drop_animation_controller_impl.cc (right): https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc#newcode88 ui/views/animation/ink_drop_animation_controller_impl.cc:88: kHoverFadeOutBeforeAnimationDurationInMs), nitty nit: I thought the second argument to ...
4 years, 8 months ago (2016-04-21 16:16:49 UTC) #3
bruthig
Updated, varkha@, can you PTAL? https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc File ui/views/animation/ink_drop_animation_controller_impl.cc (right): https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc#newcode88 ui/views/animation/ink_drop_animation_controller_impl.cc:88: kHoverFadeOutBeforeAnimationDurationInMs), On 2016/04/21 16:16:49, ...
4 years, 8 months ago (2016-04-21 21:14:04 UTC) #4
varkha
lgtm with a nit / suggestion. https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc File ui/views/animation/ink_drop_animation_controller_impl.cc (right): https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc#newcode192 ui/views/animation/ink_drop_animation_controller_impl.cc:192: hover_->FadeOut(animation_duration, explode); On ...
4 years, 8 months ago (2016-04-22 19:57:20 UTC) #5
bruthig
https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc File ui/views/animation/ink_drop_animation_controller_impl.cc (right): https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc#newcode192 ui/views/animation/ink_drop_animation_controller_impl.cc:192: hover_->FadeOut(animation_duration, explode); On 2016/04/22 19:57:20, varkha wrote: > On ...
4 years, 8 months ago (2016-04-22 21:08:20 UTC) #6
varkha
Still LGTM. https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc File ui/views/animation/ink_drop_animation_controller_impl.cc (right): https://codereview.chromium.org/1890243002/diff/20001/ui/views/animation/ink_drop_animation_controller_impl.cc#newcode192 ui/views/animation/ink_drop_animation_controller_impl.cc:192: hover_->FadeOut(animation_duration, explode); On 2016/04/22 21:08:20, bruthig wrote: ...
4 years, 8 months ago (2016-04-22 23:05:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890243002/60001
4 years, 8 months ago (2016-04-23 13:05:50 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-23 14:18:45 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 14:19:50 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/caf80a39907860be5a649a81e5418721faac2f98
Cr-Commit-Position: refs/heads/master@{#389377}

Powered by Google App Engine
This is Rietveld 408576698