ui/views/animation/ink_drop_hover_unittest.cc - Issue 1890243002: Expand the Material Design hover as it fades out when a ripple is triggered.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/animation/ink_drop_hover_unittest.cc

Issue 1890243002: Expand the Material Design hover as it fades out when a ripple is triggered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed ink_drop_hover_unittest.cc compile error. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/views/animation/ink_drop_hover.cc ('K') | « ui/views/animation/ink_drop_hover.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/views/animation/ink_drop_hover.h"	5 #include "ui/views/animation/ink_drop_hover.h"

6	6

7 #include <memory>	7 #include <memory>

8	8

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "base/memory/ptr_util.h"	10 #include "base/memory/ptr_util.h"

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 std::unique_ptr<InkDropHover> ink_drop_hover = CreateInkDropHover();	46 std::unique_ptr<InkDropHover> ink_drop_hover = CreateInkDropHover();

47 EXPECT_FALSE(ink_drop_hover->IsFadingInOrVisible());	47 EXPECT_FALSE(ink_drop_hover->IsFadingInOrVisible());

48 }	48 }

49	49

50 TEST_F(InkDropHoverTest, IsHoveredStateTransitions) {	50 TEST_F(InkDropHoverTest, IsHoveredStateTransitions) {

51 std::unique_ptr<InkDropHover> ink_drop_hover = CreateInkDropHover();	51 std::unique_ptr<InkDropHover> ink_drop_hover = CreateInkDropHover();

52	52

53 ink_drop_hover->FadeIn(base::TimeDelta::FromMilliseconds(0));	53 ink_drop_hover->FadeIn(base::TimeDelta::FromMilliseconds(0));

54 EXPECT_TRUE(ink_drop_hover->IsFadingInOrVisible());	54 EXPECT_TRUE(ink_drop_hover->IsFadingInOrVisible());

55	55

56 ink_drop_hover->FadeOut(base::TimeDelta::FromMilliseconds(0));	56 ink_drop_hover->FadeOut(base::TimeDelta::FromMilliseconds(0), false);
	varkha 2016/04/21 16:16:49 nit: document what false does here. Maybe "false / nit: document what false does here. Maybe "false /* explode /" or something like that. bruthig* 2016/04/21 21:14:04 Done. Show quoted text On 2016/04/21 16:16:49, varkha wrote: > nit: document what false does here. Maybe "false /* explode */" or something > like that. Done.
57 EXPECT_FALSE(ink_drop_hover->IsFadingInOrVisible());	57 EXPECT_FALSE(ink_drop_hover->IsFadingInOrVisible());

58 }	58 }

59	59

60 } // namespace test	60 } // namespace test

61 } // namespace views	61 } // namespace views

OLD	NEW