ui/views/animation/ink_drop_hover_unittest.cc - Issue 1890243002: Expand the Material Design hover as it fades out when a ripple is triggered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/ink_drop_hover_unittest.cc

Issue 1890243002: Expand the Material Design hover as it fades out when a ripple is triggered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Optimized InkDropHover::AnimateFade() to not trigger a transformation animation if not required. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/animation/ink_drop_hover_unittest.cc

diff --git a/ui/views/animation/ink_drop_hover_unittest.cc b/ui/views/animation/ink_drop_hover_unittest.cc

index c53e0470694cc39395951fe7b52248d993323188..a72def99967981536078a98a4be33839dba6e24d 100644

--- a/ui/views/animation/ink_drop_hover_unittest.cc

+++ b/ui/views/animation/ink_drop_hover_unittest.cc

@@ -53,7 +53,8 @@ TEST_F(InkDropHoverTest, IsHoveredStateTransitions) {

ink_drop_hover->FadeIn(base::TimeDelta::FromMilliseconds(0));

EXPECT_TRUE(ink_drop_hover->IsFadingInOrVisible());

- ink_drop_hover->FadeOut(base::TimeDelta::FromMilliseconds(0));

+ ink_drop_hover->FadeOut(base::TimeDelta::FromMilliseconds(0),

+ false /* explode */);

EXPECT_FALSE(ink_drop_hover->IsFadingInOrVisible());

}

« no previous file with comments | « ui/views/animation/ink_drop_hover.cc ('k') | no next file » | no next file with comments »