Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1889783002: [NTP Snippets] Add tests for invalid or incomplete json (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
May
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@snippets_tests_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add tests for invalid or incomplete json BUG=595723 Committed: https://crrev.com/b37b6ff6a3564ae0702a7afce6c0d699a03d456a Cr-Commit-Position: refs/heads/master@{#387279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 4 chunks +57 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1878993002 Patch 1

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889783002/1
4 years, 8 months ago (2016-04-14 09:28:36 UTC) #2
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-14 09:28:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 10:06:34 UTC) #6
May
lgtm
4 years, 8 months ago (2016-04-14 10:22:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889783002/1
4 years, 8 months ago (2016-04-14 10:49:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 10:54:18 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 10:55:26 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b37b6ff6a3564ae0702a7afce6c0d699a03d456a
Cr-Commit-Position: refs/heads/master@{#387279}

Powered by Google App Engine
This is Rietveld 408576698