components/ntp_snippets/ntp_snippets_service.h - Issue 1889783002: [NTP Snippets] Add tests for invalid or incomplete json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 1889783002: [NTP Snippets] Add tests for invalid or incomplete json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_tests_cleanup

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/ntp_snippets_service.h

diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h

index d6ab94c7f476981938ea99aa637bbf7dcdba7623..0ba1efb611d99b8eff305813c9f85b89753ee114 100644

--- a/components/ntp_snippets/ntp_snippets_service.h

+++ b/components/ntp_snippets/ntp_snippets_service.h

@@ -172,7 +172,7 @@ class NTPSnippetsService : public KeyedService {

// Timer that calls us back when the next snippet expires.

base::OneShotTimer expiry_timer_;

- const ParseJSONCallback parse_json_callback_;

+ ParseJSONCallback parse_json_callback_;

base::WeakPtrFactory<NTPSnippetsService> weak_ptr_factory_;

« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippets_service_unittest.cc » ('j') | no next file with comments »