[NTP Snippets] Clean up NTPSnippetsServiceTests

[NTP Snippets] Clean up NTPSnippetsServiceTests

BUG=595723
Committed: https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25
Cr-Commit-Position: refs/heads/master@{#386703}

[Marc Treib, 2016-04-12 14:47:13]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 14:47:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878993002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878993002/1

[Marc Treib, 2016-04-12 14:47:50]

treib@chromium.org changed reviewers:
+ maybelle@chromium.org

[Marc Treib, 2016-04-12 14:47:51]

Before adding new tests, I decided to clean up the existing ones a bit first :)
PTAL!

https://codereview.chromium.org/1878993002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service_unittest.cc (right):

https://codereview.chromium.org/1878993002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service_unittest.cc:71: ASSERT_TRUE(value);
This is a bit pointless right now - I'll add tests which provide invalid json
soon!

[Marc Treib, 2016-04-12 14:54:19]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-04-12 14:54:19]

Ah, since May is OOO today, +bauerb after all... PTAL!

[Bernhard Bauer, 2016-04-12 15:25:38]

lgtm

[commit-bot: I haz the power, 2016-04-12 15:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 15:33:49]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-04-12 16:03:10]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-04-12 16:03:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878993002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878993002/1

[commit-bot: I haz the power, 2016-04-12 16:08:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-12 16:10:38]

Description was changed from

==========
[NTP Snippets] Clean up NTPSnippetsServiceTests

BUG=595723
==========

to

==========
[NTP Snippets] Clean up NTPSnippetsServiceTests

BUG=595723

Committed: https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25
Cr-Commit-Position: refs/heads/master@{#386703}
==========

[commit-bot: I haz the power, 2016-04-12 16:10:39]

Patchset 1 (id:??) landed as
https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25
Cr-Commit-Position: refs/heads/master@{#386703}