Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1878993002: [NTP Snippets] Clean up NTPSnippetsServiceTests (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer, May
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Clean up NTPSnippetsServiceTests BUG=595723 Committed: https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25 Cr-Commit-Position: refs/heads/master@{#386703}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -71 lines) Patch
M components/ntp_snippets/ntp_snippet.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/ntp_snippets/ntp_snippet.cc View 2 chunks +25 lines, -31 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 12 chunks +29 lines, -40 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878993002/1
4 years, 8 months ago (2016-04-12 14:47:38 UTC) #2
Marc Treib
Before adding new tests, I decided to clean up the existing ones a bit first ...
4 years, 8 months ago (2016-04-12 14:47:51 UTC) #4
Marc Treib
Ah, since May is OOO today, +bauerb after all... PTAL!
4 years, 8 months ago (2016-04-12 14:54:19 UTC) #6
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-12 15:25:38 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 15:33:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878993002/1
4 years, 8 months ago (2016-04-12 16:03:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 16:08:58 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 16:10:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57b24841e5cbbd98566f5cb323bd0963d1c81d25
Cr-Commit-Position: refs/heads/master@{#386703}

Powered by Google App Engine
This is Rietveld 408576698