Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 1889753002: remove U16 support, just support F16 (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
Reviewers:
herb_g, mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : address reviewer comments, mostly fixing class/function names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -434 lines) Patch
A + bench/XferF16Bench.cpp View 3 chunks +18 lines, -31 lines 0 comments Download
D bench/XferU64Bench.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkXfermode.h View 1 4 chunks +11 lines, -14 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBlitter_PM4f.cpp View 1 3 chunks +16 lines, -21 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 1 chunk +4 lines, -6 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M src/core/SkSpriteBlitter4f.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
A src/core/SkXfermodeF16.cpp View 1 1 chunk +178 lines, -0 lines 0 comments Download
D src/core/SkXfermodeU64.cpp View 1 chunk +0 lines, -239 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889753002/1
4 years, 8 months ago (2016-04-14 14:19:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 14:31:59 UTC) #5
reed1
au revoir mes amis
4 years, 8 months ago (2016-04-14 14:37:14 UTC) #7
f(malita)
lgtm https://codereview.chromium.org/1889753002/diff/1/include/core/SkXfermode.h File include/core/SkXfermode.h (right): https://codereview.chromium.org/1889753002/diff/1/include/core/SkXfermode.h#newcode266 include/core/SkXfermode.h:266: typedef void (*LCF16Proc)(uint64_t* dst, const SkPM4f* src, int ...
4 years, 8 months ago (2016-04-14 15:22:57 UTC) #8
mtklein
lgtm, with same confusion about "LCF16"
4 years, 8 months ago (2016-04-14 15:39:59 UTC) #9
reed1
https://codereview.chromium.org/1889753002/diff/1/include/core/SkXfermode.h File include/core/SkXfermode.h (right): https://codereview.chromium.org/1889753002/diff/1/include/core/SkXfermode.h#newcode266 include/core/SkXfermode.h:266: typedef void (*LCF16Proc)(uint64_t* dst, const SkPM4f* src, int count, ...
4 years, 8 months ago (2016-04-14 15:52:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889753002/20001
4 years, 8 months ago (2016-04-14 15:52:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889753002/20001
4 years, 8 months ago (2016-04-14 15:59:47 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 16:02:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3dc6aac5da2dbeb56cda025f3699cad72e1a4b4e

Powered by Google App Engine
This is Rietveld 408576698