Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1889423002: Move Windows DPI Code from ui/gfx to ui/display (Closed)

Created:
4 years, 8 months ago by robliao
Modified:
4 years, 8 months ago
Reviewers:
oshima, sky, piman
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, extensions-reviews_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, tfarina, shuchen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, James Su, jshin+watch_chromium.org, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Windows DPI Code from ui/gfx to ui/display BUG=597761 Committed: https://crrev.com/18e220e823d94c65a507bc5edadf5623bf1601d0 Cr-Commit-Position: refs/heads/master@{#388224}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -217 lines) Patch
M ash/display/display_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/icon_loader_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/elevation_icon_setter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/minimize_button_metrics_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/blink_test_environment.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/content_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/demo/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_win_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/test/run_all_unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/win/hwnd_subclass.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/display/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/display/display.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/display/win/dpi.h View 1 chunk +12 lines, -13 lines 0 comments Download
A + ui/display/win/dpi.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ui/display/win/screen_win.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/display/win/screen_win_display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/win/screen_win_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/win/dpi.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/gfx/win/dpi.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M ui/native_theme/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/native_theme/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/native_theme/native_theme.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_separator_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889423002/1
4 years, 8 months ago (2016-04-16 00:09:22 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/133571) win_clang on ...
4 years, 8 months ago (2016-04-16 00:17:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889423002/40001
4 years, 8 months ago (2016-04-18 19:32:49 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/169930)
4 years, 8 months ago (2016-04-18 19:42:16 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889423002/60001
4 years, 8 months ago (2016-04-18 20:11:13 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/169956)
4 years, 8 months ago (2016-04-18 20:21:14 UTC) #14
robliao
oshima: Please review this CL. Thanks!
4 years, 8 months ago (2016-04-18 21:43:36 UTC) #17
oshima
lgtm https://codereview.chromium.org/1889423002/diff/60001/content/renderer/renderer_main_platform_delegate_win.cc File content/renderer/renderer_main_platform_delegate_win.cc (right): https://codereview.chromium.org/1889423002/diff/60001/content/renderer/renderer_main_platform_delegate_win.cc#newcode78 content/renderer/renderer_main_platform_delegate_win.cc:78: blink::WebFontRendering::setDeviceScaleFactor(display::win::GetDPIScale()); Can you add TODO to eliminate this? ...
4 years, 8 months ago (2016-04-18 23:26:45 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889423002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889423002/80001
4 years, 8 months ago (2016-04-18 23:40:42 UTC) #20
robliao
OWNERs, please review the path patterns under your username. Thanks! piman: content/* sky: chrome/* ui/* ...
4 years, 8 months ago (2016-04-18 23:41:28 UTC) #22
piman
lgtm
4 years, 8 months ago (2016-04-19 00:33:58 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 00:49:01 UTC) #25
sky
LGTM
4 years, 8 months ago (2016-04-19 13:14:58 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889423002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889423002/80001
4 years, 8 months ago (2016-04-19 16:41:10 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 8 months ago (2016-04-19 16:47:23 UTC) #30
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:12:55 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18e220e823d94c65a507bc5edadf5623bf1601d0
Cr-Commit-Position: refs/heads/master@{#388224}

Powered by Google App Engine
This is Rietveld 408576698