Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1899833002:
Add x86 to copy_cdb_to_output Allowed Architectures (Closed)
DescriptionAdd x86 to copy_cdb_to_output Allowed Architectures
GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86
to be specified.
BUG=604429
Committed: https://crrev.com/9612107a4aa97c640fea495fec1eca8bd70c9f76
Cr-Commit-Position: refs/heads/master@{#387992}
Patch Set 1 #Patch Set 2 : Fix Comment #
Dependent Patchsets: Messages
Total messages: 24 (12 generated)
Description was changed from ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_arch for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ========== to ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_arch for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ==========
robliao@chromium.org changed reviewers: + scottmg@chromium.org
scottmg: Please review this CL. If there's another way to get GN to specify ia32, that would also be an alternative fix. Thanks!
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899833002/1
On 2016/04/18 18:02:52, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1899833002/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1899833002/1 Actually isn't cdb compatible with either target architecture? We should just be using the x64 version if we are on a 64 platform otherwise the 32 bit one. Perhaps we should just depend it on "platform.architecture()".
On 2016/04/18 18:20:30, David Yen wrote: > On 2016/04/18 18:02:52, commit-bot: I haz the power wrote: > > Dry run: CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/1899833002/1 > > View timeline at > > https://chromium-cq-status.appspot.com/patch-timeline/1899833002/1 > > Actually isn't cdb compatible with either target architecture? We should just be > using the x64 version if we are on a 64 platform otherwise the 32 bit one. > Perhaps we should just depend it on "platform.architecture()". For windows debuggers, it's easier to match 32-bit with 32-bit and 64-bit with 64-bit. Running a 64-bit debugger with a 32-bit target process means you'll have to do an .effmach switch to x86 since you'll start out in the Windows on Windows container. It's generally just easier to use the 32-bit version with a 32-bit target.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899833002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899833002/40001
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_arch for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ========== to ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ==========
thanks, lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899833002/40001
Message was sent while issue was closed.
Description was changed from ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ========== to ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 ========== to ========== Add x86 to copy_cdb_to_output Allowed Architectures GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86 to be specified. BUG=604429 Committed: https://crrev.com/9612107a4aa97c640fea495fec1eca8bd70c9f76 Cr-Commit-Position: refs/heads/master@{#387992} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9612107a4aa97c640fea495fec1eca8bd70c9f76 Cr-Commit-Position: refs/heads/master@{#387992} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
