Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1889413002: Remove unused histograms: Net.QuicSession.21* & Net.QuicSession.6* (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, quic-dev_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@REMOVE_HISTOGRAMS
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused histograms: Net.QuicSession.21* & Net.QuicSession.6* BUG=603636

Patch Set 1 #

Total comments: 1

Patch Set 2 : sync #

Patch Set 3 : mark histograms as obsolete #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -109 lines) Patch
M net/quic/quic_connection_logger.h View 1 chunk +0 lines, -21 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 4 chunks +0 lines, -82 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 5 chunks +12 lines, -6 lines 1 comment Download

Depends on Patchset:

Issue 1889393002 Patch 20001

Messages

Total messages: 8 (2 generated)
Zhongyi Shi
4 years, 8 months ago (2016-04-15 23:51:39 UTC) #2
Zhongyi Shi
4 years, 8 months ago (2016-04-15 23:55:29 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/1889413002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1889413002/diff/1/tools/metrics/histograms/histograms.xml#oldcode27571 tools/metrics/histograms/histograms.xml:27571: - units="Received in Ranges"> Please mark these as <obsolete> ...
4 years, 8 months ago (2016-04-18 14:21:31 UTC) #5
Zhongyi Shi
On 2016/04/18 14:21:31, Alexei Svitkine wrote: > https://codereview.chromium.org/1889413002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (left): > > https://codereview.chromium.org/1889413002/diff/1/tools/metrics/histograms/histograms.xml#oldcode27571 ...
4 years, 8 months ago (2016-04-18 18:44:12 UTC) #6
Ryan Hamilton
The code changes look good, but are you sure that we're OK removing these histograms? ...
4 years, 8 months ago (2016-04-18 19:12:36 UTC) #7
Alexei Svitkine (slow)
4 years, 8 months ago (2016-04-18 20:45:08 UTC) #8 
lgtm

https://codereview.chromium.org/1889413002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1889413002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:89372: -  <affected-histogram
name="Net.QuicSession.6PacketsPatternsReceived_Some6s"/>
We still want these to be able to decode data from old versions. It's fine to
leave the affected-histograms as-is if the corresponding metrics are marked as
<obsolete>. (The suffixed versions will inherit that flag as far
dashboards/tools are concerned.)

Powered by Google App Engine
This is Rietveld 408576698