Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1889393002: Remove unused historgrams: Net.QuicEphemeralPortsSuggested (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, quic-dev_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused historgrams: Net.QuicEphemeralPortsSuggested BUG=603636 Committed: https://crrev.com/dc1f6481993e5a45bc827524bfa4cb3e5c7fc4b5 Cr-Commit-Position: refs/heads/master@{#389554}

Patch Set 1 #

Total comments: 1

Patch Set 2 : mark histogram as obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/quic/quic_stream_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1889413002 Patch 20001
Issue 1889413002 Patch 40001

Messages

Total messages: 14 (5 generated)
Zhongyi Shi
4 years, 8 months ago (2016-04-15 23:51:12 UTC) #2
Zhongyi Shi
4 years, 8 months ago (2016-04-15 23:53:09 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/1889393002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1889393002/diff/1/tools/metrics/histograms/histograms.xml#oldcode27443 tools/metrics/histograms/histograms.xml:27443: -<histogram name="Net.QuicEphemeralPortsSuggested"> Please mark it as <obsolete> instead. Thanks!
4 years, 8 months ago (2016-04-18 14:21:06 UTC) #5
Zhongyi Shi
On 2016/04/18 14:21:06, Alexei Svitkine wrote: > https://codereview.chromium.org/1889393002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (left): > > https://codereview.chromium.org/1889393002/diff/1/tools/metrics/histograms/histograms.xml#oldcode27443 ...
4 years, 8 months ago (2016-04-18 17:32:11 UTC) #6
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-18 18:19:27 UTC) #7
Ryan Hamilton
lgtm
4 years, 8 months ago (2016-04-18 19:12:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889393002/20001
4 years, 8 months ago (2016-04-25 19:21:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 20:40:45 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 20:43:05 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dc1f6481993e5a45bc827524bfa4cb3e5c7fc4b5
Cr-Commit-Position: refs/heads/master@{#389554}

Powered by Google App Engine
This is Rietveld 408576698