Chromium Code Reviews Chromium Code Reviews
Issue 1889413002:
Remove unused histograms: Net.QuicSession.21* & Net.QuicSession.6* (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@REMOVE_HISTOGRAMS| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 6e91a05c4894c1d2c57b17398dd36053b69e011f..0f212d37cb662ab1e78adc18cdbd5481ecdfc80b 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -27567,37 +27567,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| -<histogram name="Net.QuicSession.21CumulativePacketsReceived" |
| - units="Received in Ranges"> |
|
Alexei Svitkine (slow)
2016/04/18 14:21:31
Please mark these as <obsolete> instead. Thanks!
|
| - <owner>rch@chromium.org</owner> |
| - <summary> |
| - This histogram summarizes information about a 21 packet sequence, indicating |
| - for each of the 21 possible prefixes of this pattern, how many packets were |
| - received in that prefix. The first range uses buckets 0 and 1, and it |
| - describes the 1st packet in the sequence. It indicates if the first packet |
| - was missing (bucket 0), or the first packet was present (bucket 1). The |
| - second range uses buckets 2 through 4, and describes the first 2 packets in |
| - the prefix of this sequence. It indicates if there were no packets received |
| - in the first two packets (bucket 2), or there was one out of two packets |
| - received (bucket 3), or if there was two out of tow received (bucket 4). |
| - etc. etc. Reading this histogram may require post-processing in a spread |
| - sheet, but can indicate the potential value of using FEC packets to convey |
| - data. |
| - </summary> |
| -</histogram> |
| - |
| -<histogram name="Net.QuicSession.6PacketsPatternsReceived" |
| - units="Binay of Packets ACKed"> |
| - <owner>rch@chromium.org</owner> |
| - <summary> |
| - Each of the 64 buckets represents a different binary pattern of 6 |
| - consecutive packets that were received by the client. The LSB of the bucket |
| - number corresponds to the reception of the oldest packet. A bit in the |
| - bucket-number being 1 indicates the packet was received, and a 0 means the |
| - packet was never received (by the client). |
| - </summary> |
| -</histogram> |
| - |
| <histogram name="Net.QuicSession.AsyncRead" enum="Boolean"> |
| <owner>rch@chromium.org</owner> |
| <summary> |
| @@ -89294,26 +89263,6 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="Net.QuicClientHelloRejectReasons"/> |
| </histogram_suffixes> |
| -<histogram_suffixes name="Net.QuicSession.21CumulativePackets" separator="_"> |
| - <owner>rch@chromium.org</owner> |
| - <suffix name="First21" |
| - label="Only the first group of 21 packets in a connection via"/> |
| - <suffix name="Some21s" |
| - label="After the first 21, this records data for some groups of 21 |
| - consecutive sequence nmubers, arriving via."/> |
| - <affected-histogram name="Net.QuicSession.21CumulativePacketsReceived"/> |
| -</histogram_suffixes> |
| - |
| -<histogram_suffixes name="Net.QuicSession.6PacketPatterns" separator="_"> |
| - <owner>rch@chromium.org</owner> |
| - <suffix name="First6" |
| - label="Only the first group of 6 packets in a connection via"/> |
| - <suffix name="Some6s" |
| - label="After the first 6, this records patterns for some groups of 6 |
| - consecutive sequence numbers, arriving via."/> |
| - <affected-histogram name="Net.QuicSession.6PacketsPatternsReceived"/> |
| -</histogram_suffixes> |
| - |
| <histogram_suffixes name="Net.QuicSession.PacketReceived" separator="_"> |
| <owner>rch@chromium.org</owner> |
| <suffix name="Ack" |
| @@ -89356,12 +89305,6 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <suffix name="CONNECTION_BLUETOOTH" |
| label="Bluetooth are tallied, but this may include connections to a |
| mobile hotspot."/> |
| - <affected-histogram |
| - name="Net.QuicSession.21CumulativePacketsReceived_First21"/> |
| - <affected-histogram |
| - name="Net.QuicSession.21CumulativePacketsReceived_Some21s"/> |
| - <affected-histogram name="Net.QuicSession.6PacketsPatternsReceived_First6"/> |
| - <affected-histogram name="Net.QuicSession.6PacketsPatternsReceived_Some6s"/> |
| <affected-histogram name="Net.QuicSession.PacketLossRate"/> |
| <affected-histogram name="Net.QuicSession.PacketReceived_Ack"/> |
| <affected-histogram name="Net.QuicSession.PacketReceived_IsAnAck"/> |
