Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: net/quic/quic_stream_factory.cc

Issue 1889393002: Remove unused historgrams: Net.QuicEphemeralPortsSuggested (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark histogram as obsolete Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_factory.h" 5 #include "net/quic/quic_stream_factory.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1526 matching lines...) Expand 10 before | Expand all | Expand 10 after
1537 bind_type, base::Bind(&PortSuggester::SuggestPort, port_suggester), 1537 bind_type, base::Bind(&PortSuggester::SuggestPort, port_suggester),
1538 net_log.net_log(), net_log.source())); 1538 net_log.net_log(), net_log.source()));
1539 1539
1540 // Passing in kInvalidNetworkHandle binds socket to default network. 1540 // Passing in kInvalidNetworkHandle binds socket to default network.
1541 int rv = ConfigureSocket(socket.get(), addr, 1541 int rv = ConfigureSocket(socket.get(), addr,
1542 NetworkChangeNotifier::kInvalidNetworkHandle); 1542 NetworkChangeNotifier::kInvalidNetworkHandle);
1543 if (rv != OK) { 1543 if (rv != OK) {
1544 return rv; 1544 return rv;
1545 } 1545 }
1546 1546
1547 UMA_HISTOGRAM_COUNTS("Net.QuicEphemeralPortsSuggested",
1548 port_suggester->call_count());
1549 if (enable_port_selection) { 1547 if (enable_port_selection) {
1550 DCHECK_LE(1u, port_suggester->call_count()); 1548 DCHECK_LE(1u, port_suggester->call_count());
1551 } else { 1549 } else {
1552 DCHECK_EQ(0u, port_suggester->call_count()); 1550 DCHECK_EQ(0u, port_suggester->call_count());
1553 } 1551 }
1554 1552
1555 if (!helper_.get()) { 1553 if (!helper_.get()) {
1556 helper_.reset(new QuicChromiumConnectionHelper( 1554 helper_.reset(new QuicChromiumConnectionHelper(
1557 base::ThreadTaskRunnerHandle::Get().get(), clock_.get(), 1555 base::ThreadTaskRunnerHandle::Get().get(), clock_.get(),
1558 random_generator_)); 1556 random_generator_));
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
1767 // Since the session was active, there's no longer an 1765 // Since the session was active, there's no longer an
1768 // HttpStreamFactoryImpl::Job running which can mark it broken, unless the TCP 1766 // HttpStreamFactoryImpl::Job running which can mark it broken, unless the TCP
1769 // job also fails. So to avoid not using QUIC when we otherwise could, we mark 1767 // job also fails. So to avoid not using QUIC when we otherwise could, we mark
1770 // it as recently broken, which means that 0-RTT will be disabled but we'll 1768 // it as recently broken, which means that 0-RTT will be disabled but we'll
1771 // still race. 1769 // still race.
1772 http_server_properties_->MarkAlternativeServiceRecentlyBroken( 1770 http_server_properties_->MarkAlternativeServiceRecentlyBroken(
1773 alternative_service); 1771 alternative_service);
1774 } 1772 }
1775 1773
1776 } // namespace net 1774 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698