Improve named grid areas parsing

Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=418614
[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string

Committed: https://crrev.com/8fa9ade5495c6b372dfc5459da8a7179816407e3
Cr-Commit-Position: refs/heads/master@{#388504}

[rwlbuis, 2016-04-18 21:34:43]

Description was changed from

==========
grid-area-names WIP

BUG=
==========

to

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=499780

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string
==========

[rwlbuis, 2016-04-18 21:37:21]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-04-18 21:37:22]

PTAL.

[rwlbuis, 2016-04-18 21:37:46]

On 2016/04/18 21:37:22, rwlbuis wrote:
> PTAL.

BTW, not sure about the bug, could make a new one...

[Manuel Rego, 2016-04-19 07:50:28]

On 2016/04/18 21:37:46, rwlbuis wrote:
> On 2016/04/18 21:37:22, rwlbuis wrote:
> > PTAL.
> 
> BTW, not sure about the bug, could make a new one...

We actually have a grid layout bug to fix this particular issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=418614

[rwlbuis, 2016-04-19 13:06:57]

On 2016/04/19 07:50:28, Manuel Rego wrote:
> On 2016/04/18 21:37:46, rwlbuis wrote:
> > On 2016/04/18 21:37:22, rwlbuis wrote:
> > > PTAL.
> > 
> > BTW, not sure about the bug, could make a new one...
> 
> We actually have a grid layout bug to fix this particular issue:
> https://bugs.chromium.org/p/chromium/issues/detail?id=418614

Will use that one, thanks!

[rwlbuis, 2016-04-19 13:07:05]

Description was changed from

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=499780

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string
==========

to

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=418614

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string
==========

[rwlbuis, 2016-04-19 18:39:01]

On 2016/04/19 07:50:28, Manuel Rego wrote:
> On 2016/04/18 21:37:46, rwlbuis wrote:
> > On 2016/04/18 21:37:22, rwlbuis wrote:
> > > PTAL.
> > 
> > BTW, not sure about the bug, could make a new one...
> 
> We actually have a grid layout bug to fix this particular issue:
> https://bugs.chromium.org/p/chromium/issues/detail?id=418614

After looking at that bug, I tried grid-inline-
grid-inline-support-flexible-lengths-001.xht. I first had to import it, but it
passes with my patch.

Do we have to have this test in the LayoutTests? It seems to me we have not
imported any tests relying on testing-utils.js, so I wonder if that means
anything. Is the plan to do a mass import for css-grid-1 once it is ready?

[Timothy Loh, 2016-04-20 04:31:11]

lgtm

I don't think we need to import the test in this patch as long as you've checked
that it passes, but let's see what rego@ thinks.

https://codereview.chromium.org/1889143003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserIdioms.h (right):

https://codereview.chromium.org/1889143003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserIdioms.h:49: if
(isASCIIAlpha(c))
maybe for consistency with the other two functions we should just write

return isASCIIAlpha(c) || c == '_' || !isASCII(c);

[Manuel Rego, 2016-04-20 07:02:29]

On 2016/04/20 04:31:11, Timothy Loh wrote:
> I don't think we need to import the test in this patch as long as you've
checked
> that it passes, but let's see what rego@ thinks.

Yes, we're not importing the W3C Grid Layout test suite,
as it's not complete yet and it's also outdated already.
Once the test suite is ready we'll be sure to import it and make the tests pass,
fill the required bugs and so on.

So at this moment I wouldn't bother about importing the tests.

[rwlbuis, 2016-04-20 11:18:48]

https://codereview.chromium.org/1889143003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserIdioms.h (right):

https://codereview.chromium.org/1889143003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserIdioms.h:49: if
(isASCIIAlpha(c))
On 2016/04/20 04:31:11, Timothy Loh wrote:
> maybe for consistency with the other two functions we should just write
> 
> return isASCIIAlpha(c) || c == '_' || !isASCII(c);

Good idea, will fix before landing.

[rwlbuis, 2016-04-20 14:21:46]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-04-20 14:21:46]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1889143003/#ps80001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-04-20 14:22:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889143003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889143003/80001

[commit-bot: I haz the power, 2016-04-20 15:36:36]

Description was changed from

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=418614

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string
==========

to

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=418614

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string
==========

[commit-bot: I haz the power, 2016-04-20 15:36:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:23:44]

Description was changed from

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=418614

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string
==========

to

==========
Improve named grid areas parsing

Improve named grid areas parsing [1] in two ways:
1. accept any CSS whitespace, not just ' '.
2. only allow name code points besides '.' and whitespace.

Also refactor a bit so we reuse code point functions from
CSSTokenizer in CSSMarkup.

BUG=418614

[1] https://drafts.csswg.org/css-grid/#valdef-grid-template-areas-string

Committed: https://crrev.com/8fa9ade5495c6b372dfc5459da8a7179816407e3
Cr-Commit-Position: refs/heads/master@{#388504}
==========

[commit-bot: I haz the power, 2016-04-22 19:23:45]

Patchset 5 (id:??) landed as
https://crrev.com/8fa9ade5495c6b372dfc5459da8a7179816407e3
Cr-Commit-Position: refs/heads/master@{#388504}