third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html - Issue 1889143003: Improve named grid areas parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

Issue 1889143003: Improve named grid areas parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

index 98ddb9e7f1c8e4dbc7490015ac39d6f1faec7777..4495c271f489a0ea7fb1bb880217b085bb73eb76 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html

@@ -155,6 +155,10 @@

document.body.appendChild(parentElement);

parentElement.style.gridTemplateAreas = "'foo bar'";

shouldBeEqualToString("window.getComputedStyle(parentElement).getPropertyValue('grid-template-areas')", '"foo bar"')

+ parentElement.style.gridTemplateAreas = "'foo" + "\t" + "bar'";

+ shouldBeEqualToString("window.getComputedStyle(parentElement).getPropertyValue('grid-template-areas')", '"foo bar"')

+ parentElement.style.gridTemplateAreas = "'foo" + "\n" + "bar'";

+ shouldBeEqualToString("window.getComputedStyle(parentElement).getPropertyValue('grid-template-areas')", '"foo bar"')

var element = document.createElement("div");

parentElement.appendChild(element);

@@ -186,6 +190,16 @@

element.style.gridTemplateAreas = "'' ''";

shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('grid-template-areas')", "none")

+ element.style.gridTemplateAreas = "'^nav'";

+ shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('grid-template-areas')", "none")

+ element.style.gridTemplateAreas = "'n^av'";

+ shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('grid-template-areas')", "none")

+ element.style.gridTemplateAreas = "'\x04nav'";

+ shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('grid-template-areas')", "none")

+ element.style.gridTemplateAreas = "'n\x04av'";

+ shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('grid-template-areas')", "none")

debug("");

debug("FIXME: We currently don't validate that the named grid areas are <indent>.");

// <ident> only allows a leading '-'.

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt » ('j') | no next file with comments »