third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt - Issue 1889143003: Improve named grid areas parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt

Issue 1889143003: Improve named grid areas parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html ('k') | third_party/WebKit/Source/core/css/CSSMarkup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt

index d25615d93ac4cd7202e7262a4d8323b4fdbfb86a..33972e2ac59e604a332e1262bfff165eede2423a 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt

@@ -28,6 +28,8 @@ PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is

PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is "none"

Test grid-template-areas: inherit

PASS window.getComputedStyle(parentElement).getPropertyValue('grid-template-areas') is "\"foo bar\""

+PASS window.getComputedStyle(parentElement).getPropertyValue('grid-template-areas') is "\"foo bar\""

PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is "\"foo bar\""

Test invalid grid-template-areas values.

PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is "none"

@@ -35,6 +37,10 @@ PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is

PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is "none"

+PASS window.getComputedStyle(element).getPropertyValue('grid-template-areas') is "none"

FIXME: We currently don't validate that the named grid areas are <indent>.

FAIL window.getComputedStyle(element).getPropertyValue('grid-template-areas') should be none. Was "nav-up".