Avoid string allocs for CMap_GetString() return value.

Avoid string allocs for CMap_GetString() return value.

StringC's are all that's needed here. Also CMap_GetString()
and GetCode() are side-effect free, so remove calls where
the value is not used.

Committed: https://pdfium.googlesource.com/pdfium/+/b1c80fb8b843a2a345b2cd6005e591dc731355f4

[Tom Sepez, 2016-04-15 00:42:52]

Description was changed from

==========
Avoid string allocs for CMap_GetString() return value.

StringC's are all that's needed here.
==========

to

==========
Avoid string allocs for CMap_GetString() return value.

StringC's are all that's needed here. Also CMap_GetString()
and GetCode() are side-effect free, so remove calls where
the value is not used.
==========

[Tom Sepez, 2016-04-15 00:42:52]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-15 00:43:06]

Lei, for review.

[Lei Zhang, 2016-04-15 01:14:30]

lgtm

[Tom Sepez, 2016-04-15 01:16:42]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-15 01:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889003002/20001

[commit-bot: I haz the power, 2016-04-15 01:17:05]

Description was changed from

==========
Avoid string allocs for CMap_GetString() return value.

StringC's are all that's needed here. Also CMap_GetString()
and GetCode() are side-effect free, so remove calls where
the value is not used.
==========

to

==========
Avoid string allocs for CMap_GetString() return value.

StringC's are all that's needed here. Also CMap_GetString()
and GetCode() are side-effect free, so remove calls where
the value is not used.

Committed:
https://pdfium.googlesource.com/pdfium/+/b1c80fb8b843a2a345b2cd6005e591dc7313...
==========

[commit-bot: I haz the power, 2016-04-15 01:17:06]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/b1c80fb8b843a2a345b2cd6005e591dc7313...