core/fpdfapi/fpdf_font/font_int.h - Issue 1889003002: Avoid string allocs for CMap_GetString() return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/font_int.h

Issue 1889003002: Avoid string allocs for CMap_GetString() return value. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove some calls where the result is not used. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/font_int.h

diff --git a/core/fpdfapi/fpdf_font/font_int.h b/core/fpdfapi/fpdf_font/font_int.h

index fc69b0cbd9b81a2e690dfadcfee5a834d8c16a55..792377ebf09119e6fdb9206e075ab434291ace06 100644

--- a/core/fpdfapi/fpdf_font/font_int.h

+++ b/core/fpdfapi/fpdf_font/font_int.h

@@ -22,7 +22,7 @@ typedef void* FXFT_Library;

short TT2PDF(int m, FXFT_Face face);

FX_BOOL FT_UseTTCharmap(FXFT_Face face, int platform_id, int encoding_id);

-CIDSet CharsetFromOrdering(const CFX_ByteString& ordering);

+CIDSet CharsetFromOrdering(const CFX_ByteStringC& ordering);

class CPDF_CMapManager {

public:

« no previous file with comments | « core/fpdfapi/fpdf_font/cpdf_cidfont.cpp ('k') | core/fpdfapi/fpdf_font/fpdf_font_cid.cpp » ('j') | no next file with comments »