core/fpdfapi/fpdf_font/cpdf_cidfont.cpp - Issue 1889003002: Avoid string allocs for CMap_GetString() return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/cpdf_cidfont.cpp

Issue 1889003002: Avoid string allocs for CMap_GetString() return value. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove some calls where the result is not used. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/cpdf_cidfont.cpp

diff --git a/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp b/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp

index 034f6f6ecee5a9648a7dad15c9fa92fcef52f56e..6089e75ec25a46035e3bd6892d2326d56ea6ac4d 100644

--- a/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp

+++ b/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp

@@ -401,7 +401,8 @@ FX_BOOL CPDF_CIDFont::Load() {

if (m_Charset == CIDSET_UNKNOWN) {

CPDF_Dictionary* pCIDInfo = pCIDFontDict->GetDictBy("CIDSystemInfo");

if (pCIDInfo) {

- m_Charset = CharsetFromOrdering(pCIDInfo->GetStringBy("Ordering"));

+ m_Charset =

+ CharsetFromOrdering(pCIDInfo->GetStringBy("Ordering").AsStringC());

}

if (m_Charset != CIDSET_UNKNOWN)

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_font/font_int.h » ('j') | no next file with comments »