Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: net/url_request/url_request_http_job.h

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: more addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index a15604f6b88e31ecb06e2a1555410a12c9cf194c..b061cde803e0ba7bbbb3b40bd6adfb485810e504 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -45,15 +45,14 @@ class URLRequestContext;
// provides an implementation for both HTTP and HTTPS.
class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
public:
- static URLRequestJob* Factory(URLRequest* request,
- NetworkDelegate* network_delegate,
- const std::string& scheme);
-
- protected:
+ // Creates a URLRequestHttpJob. Non-test code other than HttpProtocolHandler
+ // shouldn't use this constructor directly, because HttpProtocolHandler is
+ // where HSTS redirects happen.
URLRequestHttpJob(URLRequest* request,
NetworkDelegate* network_delegate,
const HttpUserAgentSettings* http_user_agent_settings);
+ protected:
~URLRequestHttpJob() override;
// Overridden from URLRequestJob:

Powered by Google App Engine
This is Rietveld 408576698